[CLOSED] Replaced util macros in favour of cef_helpers|cef_logging ones

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.

http://brackets.io

MIT License

0 stars 0 forks source link

[CLOSED] Replaced util macros in favour of cef_helpers|cef_logging ones #370

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by ficristo Monday May 30, 2016 at 19:16 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/557

And I removed the file since now it is unused.

ficristo included the following code: https://github.com/adobe/brackets-shell/pull/557/commits

core-ai-bot commented 2 years ago

Comment by ficristo Wednesday Jun 15, 2016 at 15:02 GMT

/cc @ingorichter if you have a bit of time...

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Jun 21, 2016 at 15:31 GMT

Great job @ficristo 👍 Really appreciate it!

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Jun 21, 2016 at 15:36 GMT

I tried building remove-util branch on MAC and I am getting this error.

screen shot 2016-06-21 at 9 05 29 pm

@ficristo Could you have a look at this error?

core-ai-bot commented 2 years ago

Comment by ficristo Tuesday Jun 21, 2016 at 18:41 GMT

The defines to check the OS weren't working (not on OSX). I tryed adding the cef_build or cef_task or cef_logging headers but it causes some problems on Windows. I've copied the code to define the OS from the cef_build header, now it should work.

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Jun 21, 2016 at 19:07 GMT

I am able to build this now on MAC.

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Jun 21, 2016 at 19:08 GMT

Thanks @ficristo