[CLOSED] Moved some icons under appshell/res/1x folder

[core-ai-bot]

Issue by ficristo Tuesday May 31, 2016 at 19:25 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/558

---

I was a bit confused by these icons not be in a specific folder.

Side note: why only the icons with 1x resolution are mentioned in gyp?

---

ficristo included the following code: https://github.com/adobe/brackets-shell/pull/558/commits

[core-ai-bot]

Comment by nethip Tuesday Jun 21, 2016 at 17:33 GMT

---

@ficristo I am not sure if this change ever gets baked into the product. I see that we have manually added resources, on Windows, to cefclient.rc file.

[core-ai-bot]

Comment by ficristo Tuesday Jun 21, 2016 at 18:44 GMT

---

So they aren't needed to be defined on the gyp side? I'm a bit confused how this should work...

[core-ai-bot]

Comment by nethip Tuesday Jun 21, 2016 at 18:53 GMT

---

I don't have a Windows machine at my Home. I will check and let you know tomorrow, when I get to the office.

[core-ai-bot]

Comment by nethip Wednesday Jun 22, 2016 at 14:34 GMT

---

@ficristo I was referring to this specific code. https://github.com/adobe/brackets-shell/pull/558/files#diff-a4a63dee4259dd6b62c8cccceb28a7daR194, inside appshell.gyp. I think they are there for reference purposes as the actual resources are defined inside cefclient.rc

About the change as such, I think the general convention is, if there is no scale factor appended to an image, it is considered 1x so I am not sure if want to move them under 1x folder.

[core-ai-bot]

Comment by ficristo Thursday Jun 23, 2016 at 18:58 GMT

---

I still think it is a bit confusing how it is now but I'm fine to close this PR. It is not so important.

[core-ai-bot]

Comment by ficristo Thursday Aug 25, 2016 at 18:57 GMT

---

I close this stale PR.