search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Import cefclient-2623 code and include it on Linux build only #376

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by ficristo Sunday Oct 02, 2016 at 15:30 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/584

Since it is too hard for me to update all 3 platforms, now I would like to try to run only Linux with the newer cefclient code. I removed the tests and osr files and updated the imports, otherwise the code is a copy and paste. Actually doesn't compile without https://github.com/adobe/brackets-shell/pull/562.

ficristo included the following code: https://github.com/adobe/brackets-shell/pull/584/commits

core-ai-bot commented 2 years ago

Comment by ficristo Sunday Oct 02, 2016 at 15:32 GMT

I forgot to say, since I'm looking on at Linux, I didn't import the code specific for the other platforms.

core-ai-bot commented 2 years ago

Comment by ficristo Tuesday Oct 04, 2016 at 18:01 GMT

I noticed some references to test_runner which is define in a file not included: I've removed or commented them.

To be correct, I still cannot compile on Linux, but at least it doesn't introduce more errors.

The only change here is I've renamed appshell/cefclient_gtk.cpp → appshell/cefclient_gtk.cc (notice the extension) to match the cefclient example code

I could include all these files on other platforms but on Windows I had some problems compiling files with same name (appshell/client_app.h and appshell/common/client_app.h for example)