search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Add iphlpapi to Windows linker libs #392

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by MarcelGerber Friday Jun 16, 2017 at 19:13 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/608

This was needed for me to get the latest master to compile using Visual Studio 2015. Maybe you've added the library to the linker manually in VS, @nethip?

This won't fix the issue I've had with VS 2012, mentioned in https://github.com/adobe/brackets-shell/pull/603#issuecomment-308977273. I've now uninstalled VS 2012 and switched over to VS 2015 😄

MarcelGerber included the following code: https://github.com/adobe/brackets-shell/pull/608/commits

core-ai-bot commented 2 years ago

Comment by MarcelGerber Friday Jun 16, 2017 at 19:16 GMT

The error message I got before:

>> appshell_extensions_win.obj : error LNK2019: unresolved external symbol "_GetAdaptersInfo@8" referenced in function ""void __cdecl GetMacHash(unsigned short &,unsigned short &)" (?GetMacHash@@YAXAAG0@Z)". [C:\Users\marce\Documents\GitHub\brackets-shell\Brackets.vcxproj]
>> Release\Brackets.exe : fatal error LNK1120: 1 unresolved externals [C:\Users\marce\Documents\GitHub\brackets-shell\Brackets.vcxproj]
core-ai-bot commented 2 years ago

Comment by nethip Saturday Jun 17, 2017 at 12:28 GMT

@MarcelGerber Thanks for fixing this. Yes you were right about me adding this dependency locally. My bad!