search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Now Windows CRT dlls are packaged with Brackets executable #400

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by saurabh95 Sunday Jul 09, 2017 at 17:23 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/616

Will create another PR for master once this is merged.

saurabh95 included the following code: https://github.com/adobe/brackets-shell/pull/616/commits

core-ai-bot commented 3 years ago

Comment by ficristo Saturday Jul 29, 2017 at 12:43 GMT

Was this released? If so can it be merged? ATM, I think, the installer of 1.10 doesn't match any source code: I feel very uncomfortable about it.

core-ai-bot commented 3 years ago

Comment by saurabh95 Sunday Jul 30, 2017 at 07:39 GMT

Yeah we have packaged the msi with the required dlls, I will update the PR with packaging of required dlls.

Get Outlook for Androidhttps://aka.ms/ghei36

From: ficristo notifications@github.com Sent: Saturday, July 29, 2017 6:13:51 PM To: adobe/brackets-shell Cc: Saurabh Kathpalia; Author Subject: Re: [adobe/brackets-shell] Now Windows CRT dlls are packaged with Brackets executable (#616)

Was this released? If so can it be merged? ATM, I think, the installer of 1.10 doesn't match any source code: I feel very uncomfortable about it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadobe%2Fbrackets-shell%2Fpull%2F616%23issuecomment-318828705&data=02%7C01%7C%7Cc4edeb512e3847d7af1308d4d67f782d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636369290349327500&sdata=G6tU86BDY4rCC2vREd01KGi1rfxjVUnEhXQtKeIf5mo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFXooSKr5pUV2wzdSRjCz53U9bLigzmDks5sSykHgaJpZM4OSH-s&data=02%7C01%7C%7Cc4edeb512e3847d7af1308d4d67f782d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636369290349327500&sdata=mVOjqYjvXcQp%2F1dDCHd8i8mDUe9Dk4EBS56XLWuvJKs%3D&reserved=0.

core-ai-bot commented 3 years ago

Comment by saurabh95 Tuesday Aug 22, 2017 at 07:25 GMT

Closing this PR as raised another PR with same changes against master