search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] [Linux only] CEF Upgrade to 2785 #409

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by nethip Tuesday Dec 12, 2017 at 13:57 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/626

CEF needs to be upgraded to a later version, as the current version of CEF has some issues with menus text getting corrupt. Also CEF needs to be patched wit IME as IME handling is missing in CEF.

The following are the note worthy things.

1) Upgraded to CEF 2785 2) Moved the initialization of brackets object to Global.js 3) Forced the DPI scale factor to 1, as rendering is breaking upon launching. Surprisingly, upon resizing, the view starts to render properly. We need to revisit this in the next sprint.(This is not required anymore, as the rendering issue is now fixed with a different technique with a fake resize)

nethip included the following code: https://github.com/adobe/brackets-shell/pull/626/commits

core-ai-bot commented 3 years ago

Comment by nethip Tuesday Dec 12, 2017 at 13:58 GMT

Brackets relevant PR https://github.com/adobe/brackets/pull/13975. Both need to be merged.

core-ai-bot commented 3 years ago

Comment by nethip Wednesday Dec 20, 2017 at 06:00 GMT

@abhijitapte Could you please review this?

core-ai-bot commented 3 years ago

Comment by navch Wednesday Dec 20, 2017 at 06:03 GMT

Please keep track of 3rd point to pick that up in next sprint. Apart from that it looks good to me 👍

core-ai-bot commented 3 years ago

Comment by nethip Wednesday Dec 20, 2017 at 06:11 GMT

@navch The third option is no more required as the issue was fixed in a different way.

core-ai-bot commented 3 years ago

Comment by nethip Wednesday Dec 20, 2017 at 06:16 GMT

@abhijitapte Addressed the review comments. Please have a look at the PR.