search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Restoring the brackets alias intitialization in appshell_extensions.js #411

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by nethip Thursday Feb 01, 2018 at 05:09 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/630

This is still going to be required as brackets.app.language was getting accessed even before it was getting initialized in global.js.

I have unit tested on Win, Linux and MAC with this change and the change seems to be working fine. Also I tested by hard routing the language to "fr", and Brackets is now correctly able to take the language, defined by brackets.app.language.

Thanks @swmitra for debugging this. Could you please review this? @abhijitapte It would be great if you can review this as well.

nethip included the following code: https://github.com/adobe/brackets-shell/pull/630/commits

core-ai-bot commented 2 years ago

Comment by swmitra Thursday Feb 01, 2018 at 07:16 GMT

@nethip A very minor change just for better readability purpose. If we can define the alias "brackets" upfront while defining "appshell" and then assign the initialised "appshell" placeholder to the alias before going through the self executing member initialisation block.

core-ai-bot commented 2 years ago

Comment by nethip Thursday Feb 01, 2018 at 07:18 GMT

@swmitra Thanks for reviewing this! I will update the PR with your review comments.