search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Auto Update Framework #415

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by mbhavi Tuesday Mar 27, 2018 at 16:05 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/634

This PR includes changes for Auto Update of Brackets. The changes are with respect to: 1) Windows implementation 2) Mac implementation

ping @swmitra @nethip for review

mbhavi included the following code: https://github.com/adobe/brackets-shell/pull/634/commits

core-ai-bot commented 2 years ago

Comment by mbhavi Monday Apr 09, 2018 at 05:29 GMT

@nethip , I have addressed and committed all the required changes. Also, I have replied to all the comments. The PR is ready for review again.

core-ai-bot commented 2 years ago

Comment by lokwani Monday Apr 09, 2018 at 08:07 GMT

Installer changes LGTM

core-ai-bot commented 2 years ago

Comment by mbhavi Tuesday Apr 10, 2018 at 09:30 GMT

@nethip , addressed review comments and making auto update no-op on Linux, in 3f6d92d. The review can be resumed now.

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Apr 10, 2018 at 10:05 GMT

@mbhavi @gavankar Are the custom action DLLs like BracketsExecutor part of this PR? Can you create a wiki post merging this PR as to what the steps to generate the DLLs.

Also @mbhavi post merging this PR, can you raise a PR with unit tests for the auto update process?

core-ai-bot commented 2 years ago

Comment by gavankar Tuesday Apr 10, 2018 at 10:56 GMT

@nethip, the steps to create BracketsConfigurator.CA.dll and LaunchBrackets.CA.dll have been added to the "build-win" grunt task, these steps are completely automated through grunt. Do we still require a wiki about the steps for generating the dlls?

core-ai-bot commented 2 years ago

Comment by nethip Tuesday Apr 10, 2018 at 11:03 GMT

@gavankar Thanks for pointing out! Pretty neat! No need of adding a wiki for this.

This PR looks good. LGTM

@mbhavi Thanks for your efforts in making this happen and being patient in addressing the review comments :smile: . Really appreciate it. And great job :100: Please address the review comments in Brackets as well. Thanks!

I would merge this after @ayushrathi15 confirms the results from sanity testing.