[CLOSED] Adding maint version to brackets win installer

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.

http://brackets.io

MIT License

0 stars 0 forks source link

[CLOSED] Adding maint version to brackets win installer #420

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by gavankar Tuesday Apr 24, 2018 at 05:39 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/640

This will allow an prerelease installer to upgrade a release build easily.

gavankar included the following code: https://github.com/adobe/brackets-shell/pull/640/commits

core-ai-bot commented 2 years ago

Comment by charlieantao Tuesday Apr 24, 2018 at 05:45 GMT

LGTM

core-ai-bot commented 2 years ago

Comment by swmitra Tuesday Apr 24, 2018 at 07:00 GMT

@gavankar The change set looks good to me, but I do have one question -

Can't we bring in build number to identify a release internally? Let the version string act like a label for the version, but all comparisons should be done based on build number. Otherwise we are left with same problem if we refresh a build...

core-ai-bot commented 2 years ago

Comment by gavankar Tuesday Apr 24, 2018 at 08:28 GMT

@swmitra you are right that build number would be better. But i could not find any variable/property from which to get the build number while grunt is creating the installer.