[CLOSED] Disable custom drag handlers if OS is linux

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.

http://brackets.io

MIT License

0 stars 0 forks source link

[CLOSED] Disable custom drag handlers if OS is linux #422

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by boopeshmahendran Friday Apr 27, 2018 at 12:12 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/642

This PR disables custom drag handlers to make CEF fallback to default behavior

boopeshmahendran included the following code: https://github.com/adobe/brackets-shell/pull/642/commits

core-ai-bot commented 2 years ago

Comment by vickramdhawal Friday Apr 27, 2018 at 12:17 GMT

@boopeshmahendran Can you put in more details in the PR to understand how this change helps.

core-ai-bot commented 2 years ago

Comment by boopeshmahendran Friday Apr 27, 2018 at 12:37 GMT

Before this change, on Linux, the events related to drag and drop such as dragover and drop were not triggered on the brackets side and as a result, the drag and drop feature in file tree was not working. This changes fixes that issue by disabling the custom drag and drop handling (for Linux only) and making CEF fallback to the default behavior.

core-ai-bot commented 2 years ago

Comment by vickramdhawal Friday Apr 27, 2018 at 12:56 GMT

LGTM 👍