search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Improved console error messages #441

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by jha-g Friday Nov 15, 2019 at 09:17 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/669

For --remote-debugging-port beyond allowed range, error message will be:

$ ./xcodebuild/Release/Brackets.app/Contents/MacOS/Brackets --remote-debugging-port=65535
[1115/144405:ERROR:cefclient.cpp(116)] Cannot enable remote debugging on port 65535. Port numbers should be between 1025 and 65534.

For --remote-debugging-port beyond parsing range of strtol, error message will be:

$ ./xcodebuild/Release/Brackets.app/Contents/MacOS/Brackets --remote-debugging-port=99999999999999999999
[1115/144412:ERROR:cefclient.cpp(104)] Could not enable remote debugging. Error while parsing remote-debugging-port arg: 99999999999999999999

jha-g included the following code: https://github.com/adobe/brackets-shell/pull/669/commits

core-ai-bot commented 2 years ago

Comment by jha-g Friday Nov 15, 2019 at 09:18 GMT

@niteskum @shubhsnov @narayani28

core-ai-bot commented 2 years ago

Comment by niteskum Friday Nov 15, 2019 at 09:23 GMT

LGTM

core-ai-bot commented 2 years ago

Comment by jha-g Monday Nov 18, 2019 at 08:16 GMT

This is in continuation from PR https://github.com/adobe/brackets-shell/pull/668