search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] moving command line error to infobar and fixing windows port range issues #442

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by jha-g Wednesday Nov 20, 2019 at 13:46 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/673

Windows was allowing Brackets to open a remote debugging port on any port in the range [1,65534], which was troubling. So, have started setting settings.remote_debugging_port=65535 in case of ports outside the interval [1024,65534]. Which stops Brackets from opening a reserved port and this stops error thrown in bind() on Linux and Mac.

jha-g included the following code: https://github.com/adobe/brackets-shell/pull/673/commits

core-ai-bot commented 2 years ago

Comment by jha-g Thursday Nov 21, 2019 at 10:00 GMT

Reference to setting remote-debugging-port to 65535 to disable remote debugging: CEF 2785 CEF 2623 CEF 2704

And CEF has fixed this issue of not validating reserved ports, interval [0,1023], in later branches: CEF 3202

core-ai-bot commented 2 years ago

Comment by jha-g Thursday Nov 21, 2019 at 10:16 GMT

@shubhsnov renamed the error string variable, as suggested.