search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Shell Api to get default Application for a file type #443

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by niteskum Thursday Mar 12, 2020 at 19:53 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/677

API is added to get Default Application for a file type. Api Name: getSystemDefaultApp This takes input as comma separated file extensions string and return comma separated OS Default Application for each extensions if any.

@swmitra @shubhsnov @sobisht @jha-g @narayani28 please review

niteskum included the following code: https://github.com/adobe/brackets-shell/pull/677/commits

core-ai-bot commented 2 years ago

Comment by jha-g Wednesday Mar 18, 2020 at 07:39 GMT

Address these minor issues, rest looks good.

core-ai-bot commented 2 years ago

Comment by niteskum Wednesday Mar 18, 2020 at 08:36 GMT

made the suggested changes

core-ai-bot commented 2 years ago

Comment by jha-g Wednesday Mar 18, 2020 at 08:57 GMT

LGTM