search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

Fix for loading the icon list in Linux #452

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by radorodopski Friday Oct 24, 2014 at 22:31 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/483

This commit fixes a couple of things:

  1. The list of icons was using relative paths.
  2. If the icons could not be loaded, the error was ignored without a warning.

For 1) I am prefixing the icon paths with the directory where the Brackets executable resides (since the icons are there, too). One might think that the paths are relative to the aforementioned directory, except that is only true if Brackets is started from the launcher. If I start Brackets from the command line (or if I specify another initial working dir), Brackets fails to load the icons. On top of that, no warning is issued to the user, making this hard to trace as my window manager cached the icons (so for testing I had to rename the executable, too). Which leads me to 2), now I'm issuing a warning if Brackets fails to load any of the icons. The bug was originally pointed out to me by another user - @orschiro on github.

Here's what it looks like: icon_bug_cropped

To reproduce the issue:

  1. Start a terminal
  2. cd ~/
  3. sudo cp /opt/brackets/Brackets /opt/brackets/test1
  4. /opt/brackets/test1

Running the copy of the Brackets executable from 4) is necessary in order to bypass any cache the window manager might have.

radorodopski included the following code: https://github.com/adobe/brackets-shell/pull/483/commits

core-ai-bot commented 2 years ago

Comment by radorodopski Friday Oct 24, 2014 at 22:32 GMT

This should fix https://github.com/adobe/brackets/issues/7141

core-ai-bot commented 2 years ago

Comment by nethip Monday Mar 16, 2015 at 09:39 GMT

@radorodopski Did you get a chance to look at the suggested changes?