search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

Fix for #10686: White line along right edge of UI on high-DPI Windows #453

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by nethip Friday Mar 06, 2015 at 11:53 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/507

This is a fix contributed by @fxb. This fix address the thin white line problem that appears just below the menu bar randomly.

nethip included the following code: https://github.com/adobe/brackets-shell/pull/507/commits

core-ai-bot commented 2 years ago

Comment by nethip Friday Mar 06, 2015 at 11:53 GMT

CC @JeffryBooher @redmunds @peterflynn Please review this change.

core-ai-bot commented 2 years ago

Comment by nethip Monday Mar 09, 2015 at 10:38 GMT

@JeffryBooher Thanks for pointing out this and proving more info! I will look into this.

core-ai-bot commented 2 years ago

Comment by deandersson Friday Jun 19, 2015 at 22:52 GMT

@nethip to be able to get the menu bar to render in the active color we can add mIsActive = (BOOL)wParam;to the WM_ACTIVATE case aswell since the rest of the function is the same.

But as @JeffryBooher pointed out what else might be broken? MSDN has a remark about the WM_ACTIVATE message, that DefWindowProc handles keyboard focus when the window gets activated. I tried this by opening a second instance from the debug menu and when DefWindowProc doesnt run the second instance never gets keyboard focus, so you can click in the second instance and activate it but when you type it goes in the first instance..

I could not replicate this problem when switching between other processes though. I tried several variations and could not really find anything that was broken when using this fix. There are probably more variations I could try but its over midnight now.. soo nighty night! :smile:

core-ai-bot commented 2 years ago

Comment by JeffryBooher Friday Jun 19, 2015 at 23:28 GMT

We should try playing around with the Window Class and make the background brush black. It's white by default. That might minimize the White Line flicker.