search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

Windows 64 build #456

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by jha-g Tuesday Apr 02, 2019 at 12:09 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/664

Windows 64 bit build can be done using following commands. I am using this build as my default brackets and have not seen any issue yet. TODO: installer is not working.

grunt setup --force-target-word-size=64 
grunt build  --force-target-word-size=64

jha-g included the following code: https://github.com/adobe/brackets-shell/pull/664/commits

core-ai-bot commented 2 years ago

Comment by shubhsnov Tuesday Apr 02, 2019 at 12:15 GMT

Nit: Change the command line flag: to --arch=x64 instead of --force-target-word-size=64

core-ai-bot commented 2 years ago

Comment by jha-g Friday May 03, 2019 at 11:59 GMT

Addressed review comments. commands to setup and build becomes(ia32 is default):

grunt setup --arch=[x64|ia32] 
grunt build  --arch=[x64|ia32]
core-ai-bot commented 2 years ago

Comment by jha-g Tuesday May 28, 2019 at 10:55 GMT

Hi @vickramdhawal, I've addressed all the review comments.