[CLOSED] Use Win32 API to get file mod time.

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.

http://brackets.io

MIT License

0 stars 0 forks source link

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by gruehle Friday Sep 14, 2012 at 18:37 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/113

Fix for issue adobe/brackets#1647

The _wstat() function on Windows does not work with symlinks (see the 2nd note on this page: http://msdn.microsoft.com/en-us/library/14h5k7ff.aspx). Use the Win32 API to get the file mod time instead.

All unit tests pass.

gruehle included the following code: https://github.com/adobe/brackets-shell/pull/113/commits

core-ai-bot commented 3 years ago

Comment by redmunds Friday Sep 14, 2012 at 21:59 GMT

Done with initial review.

core-ai-bot commented 3 years ago

Comment by gruehle Friday Sep 14, 2012 at 23:41 GMT

Comments have been addressed. Ready for re-review.

core-ai-bot commented 3 years ago

Comment by redmunds Saturday Sep 15, 2012 at 00:10 GMT

This looks good on Win7. Do you think it's ok to merge, or should we get someone to try it out on WinXP first?

core-ai-bot commented 3 years ago

Comment by redmunds Saturday Sep 15, 2012 at 00:35 GMT

Merging to get it in tonite's build.