search

brackets-archive / brackets.io

brackets.io website
0 stars 0 forks source link

[CLOSED] Update normalize.css #101

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by coliff Thursday Apr 16, 2015 at 09:19 GMT Originally opened as https://github.com/adobe/brackets.io/pull/147

Updated to Normalize v3.0.3 Used minified version for smaller file size / faster loading

coliff included the following code: https://github.com/adobe/brackets.io/pull/147/commits

core-ai-bot commented 3 years ago

Comment by ficristo Friday Sep 23, 2016 at 18:17 GMT

Could you use the not minimized file?

core-ai-bot commented 3 years ago

Comment by coliff Monday Sep 26, 2016 at 08:00 GMT

Would it not be better to use the minified version for production though? The larger filesize impacts load times. https://developers.google.com/speed/pagespeed/insights/?url=brackets.io

core-ai-bot commented 3 years ago

Comment by ficristo Monday Sep 26, 2016 at 18:45 GMT

I was going to reconsider my decision but I just checked the normalize repo doesn't offer the minified version and sincerly I don't like that the minified step wasn't part of our build. Since we don't have a build system and I really doubt the minification could save much, I still prefer the non minified version.

core-ai-bot commented 3 years ago

Comment by coliff Tuesday Sep 27, 2016 at 10:50 GMT

cool. no problem. I'll update my PR

core-ai-bot commented 3 years ago

Comment by coliff Tuesday Sep 27, 2016 at 11:04 GMT

This PR can be closed now as I opened a new one: https://github.com/adobe/brackets.io/pull/186