Open core-ai-bot opened 3 years ago
Comment by nethip Saturday May 09, 2015 at 10:38 GMT
@fmoliveira I think we already have these translations in the core. https://github.com/adobe/brackets/tree/master/src/nls/pt-br. Are you referring to the same strings?
Comment by nethip Saturday May 09, 2015 at 10:40 GMT
@fmoliveira Oh I see now that you were referring to adding new language to the website. My bad as I thought it was to do with Brackets core.
Comment by nethip Saturday May 09, 2015 at 10:42 GMT
Marking this to @ryanstewart for his inputs on this.
Comment by fmoliveira Saturday May 09, 2015 at 12:52 GMT
Hi @nethip , yes I mean adding the new translation to the website. No problem! :smiley:
I'll await for @ryanstewart answer. Thanks!
Comment by MarcelGerber Tuesday May 12, 2015 at 15:27 GMT
@fmoliveira I think you're pretty safe with that as there hasn't been much interest in translating this page lately.
In case you need help, I'm probably the one to ask as I've integrated the i18next library and provided the German translation.
There are presumably some small changes we have to make to the localization system over here (the one that comes to mind is accepting locales consisting of two parts, like pt-br
does).
Comment by fmoliveira Tuesday May 12, 2015 at 16:46 GMT
Fine @MarcelGerber , that's exactly what I thought.
Good to know who to ask help for. I'll start working on the translation then. :+1:
Thanks!
Comment by nethip Tuesday May 12, 2015 at 16:59 GMT
@fmoliveira I think this page cannot be completely localized as updates strings that fill the bottom left part of the website telling about release highlights, are right now localized only in 5 languages and we do not have update strings for pt-br. I will have a word with Ryan, who is the product manager for Brackets.
Comment by fmoliveira Tuesday May 12, 2015 at 17:03 GMT
I see @nethip , you mean the "release notes" section?
If I can help translating the release notes I'll be happy to help too. :smiley:
Comment by ryanstewart Tuesday May 12, 2015 at 17:05 GMT
@fmoliveira I think translating the page in the same way @MarcelGerber did for German would be awesome! As @nethip mentions, the release notes won't necessarily be translated (and I don't think we have the infrastructure set up for those) but translating the blog would be awesome.
Comment by nethip Tuesday May 12, 2015 at 17:06 GMT
@fmoliveira I just had a word with Ryan. Please go ahead and add the translation. :smile:
Comment by MarcelGerber Tuesday May 12, 2015 at 18:01 GMT
@fmoliveira You can translate Brackets' Update Notifications over here, but let's start with the website.
Comment by fmoliveira Tuesday May 12, 2015 at 18:19 GMT
Thanks a lot @ryanstewart , @nethip and @MarcelGerber .
Fine @MarcelGerber , good to know. You're right, let's start with the website. :+1:
Comment by fmoliveira Wednesday Jul 08, 2015 at 12:56 GMT
So sorry it's taking too much time to finish this. In fact I've already finished the translation but wasn't able to manage time to review it. I'll take care of it this week and submit a pull request.
Comment by fmoliveira Thursday Jul 23, 2015 at 01:35 GMT
Phew! I've finally been able to do my last review and submit the translation!
PR #161 has been sent. :smiley:
Comment by abose Thursday Jul 23, 2015 at 05:02 GMT
@fmoliveira The pr has been merged. Please close this issue once you verfied this after release 1.4 goes live.
Comment by fmoliveira Thursday Jul 23, 2015 at 11:49 GMT
Fine @abose , I'll keep an eye on that!
Thanks.
Comment by fmoliveira Thursday Jul 23, 2015 at 11:55 GMT
Release 1.4 isn't out yet but the website has already been updated.
Everything is just fine. I'm closing this.
Issue by fmoliveira Friday May 08, 2015 at 19:40 GMT Originally opened as https://github.com/adobe/brackets.io/issues/151
Hello,
I love Brackets and I'd like to translate its website to my native tongue, Brazilian Portuguese.
I've already read locale's README and I'm opening an issue just to make sure nobody else is working at the same task.
May I start working on the translation? :smiley:
Thanks in advance!