search

brackets-archive / brackets.io

brackets.io website
0 stars 0 forks source link

[CLOSED] Tweaks. #2

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by larz0 Friday Sep 27, 2013 at 07:20 GMT Originally opened as https://github.com/adobe/brackets.io/pull/1

larz0 included the following code: https://github.com/adobe/brackets.io/pull/1/commits

core-ai-bot commented 3 years ago

Comment by larz0 Sunday Sep 29, 2013 at 19:12 GMT

Thanks @yomi0. We need to hide it based on the device and not screen size.

@adrocknaphobia thoughts?

core-ai-bot commented 3 years ago

Comment by GarthDB Sunday Sep 29, 2013 at 19:25 GMT

Topcoat is hiding it based on screen size and it seems to work alright.

core-ai-bot commented 3 years ago

Comment by larz0 Sunday Sep 29, 2013 at 19:55 GMT

What size do you recommend?

core-ai-bot commented 3 years ago

Comment by GarthDB Sunday Sep 29, 2013 at 21:44 GMT

I believe it is either 880px or 940px.

core-ai-bot commented 3 years ago

Comment by larz0 Sunday Sep 29, 2013 at 21:45 GMT

That will probably show up on landscape mode on certain devices.

core-ai-bot commented 3 years ago

Comment by GarthDB Sunday Sep 29, 2013 at 21:47 GMT

940 might work but you're right.

I wonder if there's something in modernizr for this.

core-ai-bot commented 3 years ago

Comment by larz0 Sunday Sep 29, 2013 at 22:27 GMT

Paul Irish recommended http://detector.dmolsen.com

core-ai-bot commented 3 years ago

Comment by GarthDB Sunday Sep 29, 2013 at 22:28 GMT

Never argue with the Irish.

core-ai-bot commented 3 years ago

Comment by larz0 Sunday Sep 29, 2013 at 22:37 GMT

DULY NOTED.