search

brackets-archive / brackets.io

brackets.io website
0 stars 0 forks source link

[CLOSED] Download Button Not Recognizing Firefox 32-bit #24

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by adrocknaphobia Tuesday Oct 22, 2013 at 17:21 GMT Originally opened as https://github.com/adobe/brackets.io/issues/26

The download button displays "unknown" when browsing the site with Firefox 32-bit.

https://github.com/adobe/brackets/issues/5509

core-ai-bot commented 3 years ago

Comment by lkcampbell Tuesday Oct 29, 2013 at 21:29 GMT

@adrocknaphobia, I have this problem in Chrome as well. Version 30.0.1599.101 m.

The download button says "Sprint 32 (UNKNOWN)" if I go to http://brackets.io/ and if I click on the button, is goes to an error page that says:

struct DETAIL [empty string] MESSAGE Invalid platform.

On the other hand, the Download Button at http://download.brackets.io/ works great! That's the page and button I have been using to get all of my latest Sprint downloads.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Oct 29, 2013 at 21:30 GMT

@lkcampbell What's your user agent?

core-ai-bot commented 3 years ago

Comment by lkcampbell Tuesday Oct 29, 2013 at 21:31 GMT

Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

core-ai-bot commented 3 years ago

Comment by pthiess Saturday Nov 09, 2013 at 00:55 GMT

@adrocknaphobia Are you still on this or shall we reassign?

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Nov 11, 2013 at 19:18 GMT

Reviewed. Will reassign to @ingorichter once he's been added to the repo.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Nov 11, 2013 at 19:18 GMT

Note: we should also make sure this is fixed for various browsers on 32-bit Win XP (see adobe/brackets#5914)

core-ai-bot commented 3 years ago

Comment by adrocknaphobia Wednesday Nov 13, 2013 at 03:46 GMT

Should be working for all XP browsers now.

core-ai-bot commented 3 years ago

Comment by TuckerWhitehouse Wednesday Nov 13, 2013 at 15:36 GMT

If(OS != "Unknown") is NEVER going to return false (Line 287) because the default value given on Line 259 is var OS = "UNKNOWN" (all caps).

core-ai-bot commented 3 years ago

Comment by pthiess Wednesday Nov 13, 2013 at 19:18 GMT

@adrocknaphobia I do agree with @TuckerWhitehouse in case of an unknown OS version and label are set to an undefined value. It would be great to handle that case. Your fix seems to address XP, but not necessarily unsupported platforms.

core-ai-bot commented 3 years ago

Comment by adrocknaphobia Wednesday Nov 13, 2013 at 20:10 GMT

Thanks @TuckerWhitehouse. Good catch. I fixed the issue w/ PR #34. In the future, feel free to submit pull requests directly against this repo. It's my hope that we can handle these minor cosmetic issues without having to bother the Brackets team whose time is better spent working on Brackets itself.