search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Add "replace all" button when doing find and replace #10070

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by amrelnaggar Wednesday Aug 19, 2015 at 03:27 GMT Originally opened as https://github.com/adobe/brackets/pull/11606

For #11126.

amrelnaggar included the following code: https://github.com/adobe/brackets/pull/11606/commits

core-ai-bot commented 3 years ago

Comment by ficristo Thursday Sep 29, 2016 at 17:46 GMT

I didn't look closely at the code but I wonder if changing the button id could break extensions. That said this needs at least a test.

core-ai-bot commented 3 years ago

Comment by amrelnaggar Saturday Nov 19, 2016 at 19:10 GMT

Sorry I've been pretty busy.

I didn't think about extensions. Would it be better if I kept the button id as it was and made a new id for Replace all button? Or unit tests will be enough?

core-ai-bot commented 3 years ago

Comment by ficristo Tuesday Nov 22, 2016 at 20:04 GMT

@amrelnaggar I looked around on the public available extensions and I think this is safe as is. So only the test is needed.

It is only to understand if this is something that would be contributed back from Adobe:@swmitra@madanbn?

core-ai-bot commented 3 years ago

Comment by amrelnaggar Monday Nov 28, 2016 at 19:38 GMT

I added the test.

core-ai-bot commented 3 years ago

Comment by ficristo Tuesday Dec 13, 2016 at 19:54 GMT

@amrelnaggar could you merge master so to resolve the conflicts?

core-ai-bot commented 3 years ago

Comment by amrelnaggar Friday Dec 16, 2016 at 12:03 GMT

@ficristo All conflicts have been resolved.

If there is anything else needs to be done just let me know.

core-ai-bot commented 3 years ago

Comment by ficristo Friday Dec 16, 2016 at 18:57 GMT

Something went wrong. It seems you merged an old version of master. You can use git rebase -i ... to drop the last two commits and then try to run git fetch upstream and merge again upstream/master Alternatively you can open a new fresh PR.

core-ai-bot commented 3 years ago

Comment by amrelnaggar Saturday Dec 17, 2016 at 18:23 GMT

@ficristo I created a new PR #12988.

Closing this PR.