search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] CMD=F or CTRL-F switches to Window > Enter Full Screen #10191

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by geooogle Tuesday Oct 06, 2015 at 17:35 GMT Originally opened as https://github.com/adobe/brackets/issues/11782

Release 1.4 build 1.4.0-16380 (release 273804eb3) build timestamp: Sun Jul 26 2015 23:20:45 GMT-0700

On a mac anyway, when you hit CMD-F you usually get the Find bar (obviously.) But after about 20-50 uses, CMD-F acts like Window > Enter Full Screen. Even the Symbol for CMD-F is shown in the menu item (Enter Full Screen).

When bug exists:

screen shot 2015-10-06 at 1 32 49 pm screen shot 2015-10-06 at 1 33 09 pm

After restarting brackets: screen shot 2015-10-06 at 1 33 27 pm screen shot 2015-10-06 at 1 33 33 pm

core-ai-bot commented 3 years ago

Comment by mattbell87 Tuesday Oct 06, 2015 at 23:40 GMT

I'm on OSX Yosemite 10.10.5 with the same build as you. I can't get this bug to replicate, even if I hold down Cmd-F. What extensions do you have? (Not a brackets dev btw, just curious)

core-ai-bot commented 3 years ago

Comment by geooogle Wednesday Oct 07, 2015 at 00:03 GMT

This only started happening after a format, fresh install of El Capitan 10.11 (15A284) on a MacBookAir. Never on Yosemite.

Extensions:

Thanks!

core-ai-bot commented 3 years ago

Comment by mattbell87 Wednesday Oct 07, 2015 at 02:06 GMT

Out of the extensions you have installed I only have Brackets Git 14.32. You could try a fresh Brackets install (or maybe rename the ~/Library/Application Support/Brackets folder) and see if it still happens. If it does then it may be an El Captain issue!

core-ai-bot commented 3 years ago

Comment by abose Wednesday Oct 07, 2015 at 08:38 GMT

Once the shortcut stops working, can you go to debug>show developer tools> console and post the errors here?

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Wednesday Oct 07, 2015 at 11:46 GMT

This issue started to happen to me also after i updated to El Capitan a few days ago. No changes in extensions. I am probably going to tale a closer look today or tomorrow as this is really disabling for me.

core-ai-bot commented 3 years ago

Comment by geooogle Wednesday Oct 07, 2015 at 16:15 GMT

@abose I encountered the issue just now. It occurred after CMD-R and I can now recreate the issue.

In any case, I reloaded without extensions and same occurred.

image

core-ai-bot commented 3 years ago

Comment by shichongrui Wednesday Oct 07, 2015 at 17:23 GMT

I have the same problem and closing brackets and then opening it again seems to bring back the desired find functionality with CMD-F

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Wednesday Oct 07, 2015 at 18:54 GMT

So, I restarted brackets after I pulled from master and I have the find key binding back... I am guessing brackets restart fixed it though. Odd. Never seen this issue before.

core-ai-bot commented 3 years ago

Comment by breadadams Thursday Oct 08, 2015 at 21:36 GMT

This same issue has just started happening for me too. Randomly midday during work, after using brackets for a couple of hours. Just quit and relaunched and cmd + F is back to finding.

I have none of the same extensions as@geooogle

core-ai-bot commented 3 years ago

Comment by ingorichter Thursday Oct 08, 2015 at 22:24 GMT

I hit the same thing last night. After restarting Brackets, it went away. But there might be something more to it, that causes this behavior. Interesting fact, is that the shortcut CMD+F disappears from the menu.

core-ai-bot commented 3 years ago

Comment by geooogle Friday Oct 09, 2015 at 12:49 GMT

@breadadams Did you try refreshing Brackets to see if that was the cause? It's not random as far as I can tell.

I refresh Brackets when I need give Brackets Git 0.14.32 a clean look at what was just pushed or pulled. Then the frustration begins.

core-ai-bot commented 3 years ago

Comment by breadadams Friday Oct 09, 2015 at 12:55 GMT

@geooogle Do you mean a cmd + R refresh? If so, yeah - tried that, but no change. Like I said, only quitting and opening Brackets again fixed the issue. Not ran into again since then.

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Friday Oct 09, 2015 at 12:57 GMT

@breadadams yup, that did it for me as well. Quit then re-open.

core-ai-bot commented 3 years ago

Comment by geooogle Friday Oct 09, 2015 at 13:05 GMT

@breadadams What I mean is:

As far as I can tell, the problem spawns from cmd + R OR option + cmd + R

core-ai-bot commented 3 years ago

Comment by breadadams Friday Oct 09, 2015 at 13:07 GMT

@geooogle AHA! Sorry, completely mis-read you. That is the issue, if you press cmd + R then open the Find menu item, you see the shortcuts all start blinking/flashing and finally cmd + F disappears from the main Find option.

core-ai-bot commented 3 years ago

Comment by nethip Friday Oct 09, 2015 at 13:34 GMT

Phew! Finally fixed it with this PR. The fix is not documented and it took a while for me to figure out what is going on.

Apple mandates all applications to have "Enter Full Screen" menu which executes "toggleFullScreen:" and target as nil. Now if applications don't do that, they are going to add this menu to menubar.

So added the a new menu "Enter Full Screen" with shortcut as Ctrl-Cmd-F. This will make sure the OS does not go about randomly assigning shortcuts to "Enter Full Screen".

Another interesting observation is the fact that, OS automatically substitutes the language equivalent of "Enter Full Screen" for the current system language, provided we have the resource files for that languages. So in our case, this menu entry is automatically translated in cases of french and jp as we have resource files for tose. Unfortunately for other languages the menu is going to be in english which is the same case with "Minimize" and "Zoom" menus. It is really weird!

Now what is also weird is the fact that this behavior is observed only on El Capitan and not on Yosemite.

@ingorichter@abose@madanbn Will you be able to review this PR? Let us target this for 1.5. I have not tested this with Mountain Lion. Hopefully it should work just fine there as well.

core-ai-bot commented 3 years ago

Comment by Seakla Thursday Oct 15, 2015 at 01:41 GMT

Another quick workaround while we wait for 1.5 to be released:

If you don't use the Reload shortcut all that much, you can temporarily override it in your key bindings. Process is outlined here: https://github.com/adobe/brackets/wiki/User-Key-Bindings

I used "Cmd-R": "" which removes the shortcut entirely for the moment.

core-ai-bot commented 3 years ago

Comment by abose Thursday Oct 15, 2015 at 06:04 GMT

Thanks for stepping in with a workaround! nb: 1.5 will be released today :)

core-ai-bot commented 3 years ago

Comment by geooogle Thursday Oct 15, 2015 at 13:05 GMT

@nethip Thanks for the fix!

core-ai-bot commented 3 years ago

Comment by nethip Thursday Oct 15, 2015 at 13:24 GMT

@geooogle No problem ! We have fixed all full screen related issues on El Capitan. Please install 1.5 and let us know if you are still facing the issue.