[CLOSED] Code review tweaks for JS inline editor.

core-ai-bot commented 3 years ago

Issue by njx Wednesday Jun 13, 2012 at 22:04 GMT Originally opened as https://github.com/adobe/brackets/pull/1043

@jason-sanjose

Main tweaks:

Got rid of extra regexp for detecting funcName: function()--merged that case into the regexp that was already handling funcName = function().
Got rid of redundant outer loop in _findAllMatchingFunctions(), changing it to a preflight that bails early if no matches are found.

Plus a couple other smaller changes.

njx included the following code: https://github.com/adobe/brackets/pull/1043/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Jun 13, 2012 at 22:43 GMT

Initial review complete. I had an error in my comment earlier, might need to refresh to be sure GitHub isn't stale.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Jun 13, 2012 at 23:42 GMT

Updated with code review tweak.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Jun 13, 2012 at 23:42 GMT

@jason-sanjose Ready for re-review.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Jun 13, 2012 at 23:45 GMT

Looks good. Merging.

brackets-archive / bracketsIssues