search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Remove .jsx from Javascript file extensions and create an jsx-mode #10380

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by petetnt Tuesday Jan 05, 2016 at 07:52 GMT Originally opened as https://github.com/adobe/brackets/pull/12052

This PR removes .jsx from Javascript file extensions and creates an separate jsx-mode.

petetnt included the following code: https://github.com/adobe/brackets/pull/12052/commits

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Saturday Feb 13, 2016 at 16:09 GMT

@petetnt we have used the convention in the past to put in the title of the PR "[DO NOT MERGE]" or something to that extent for a more visual cue of the status of the PR.

Correction. I think the convention was "[REVIEW ONLY]"... :)

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Saturday Feb 13, 2016 at 16:13 GMT

Looking forward to this :)

core-ai-bot commented 3 years ago

Comment by petetnt Saturday Feb 13, 2016 at 16:52 GMT

@MiguelCastillo Yeah that's probably a good idea. I changed the title :+1:

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Saturday Feb 13, 2016 at 18:52 GMT

I created and added a label to track PRs that shouldn't be merged. :) Easier to filter

core-ai-bot commented 3 years ago

Comment by petetnt Wednesday Apr 06, 2016 at 12:48 GMT

CodeMirror is now merged so this should be too. Ping@MiguelCastillo

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Wednesday Apr 06, 2016 at 13:26 GMT

@petetnt Yup - this is my next item on the list :)

core-ai-bot commented 3 years ago

Comment by MarcelGerber Friday May 13, 2016 at 15:15 GMT

I think this is an easy merge now. Is there something blocking this,@MiguelCastillo@petetnt?

core-ai-bot commented 3 years ago

Comment by petetnt Friday May 13, 2016 at 17:18 GMT

@MarcelGerber nope AFAIK. Just needed the CodeMirror update. Cannot remove the do not merge tag myself but there shouldn't be anything to stop merging this, actually merging this would be really beneficial 💰

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Friday May 13, 2016 at 18:47 GMT

Yeah you guys are right. I completely disappeared for a bit and neglected. Merging now.

core-ai-bot commented 3 years ago

Comment by MiguelCastillo Friday May 13, 2016 at 18:49 GMT

It works very nicely too! Thank you@petetnt.