search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix12131: release refresh 1.6: added one more shortcut ctrl+shift+1 to toggle panels #10520

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by abose Thursday Feb 25, 2016 at 06:37 GMT Originally opened as https://github.com/adobe/brackets/pull/12243

default toggle panel shortcut was ctrl+shift+as it is present in one vertical line in the keyboard. However, we later learnt from IQE team than non-English keyboards does not have the char. So added one more shortcut ctrl+shift+1 which will be preferred.

Long term solution for locale specific shortcuts maybe to have a locale filter just like the os filter we have while registering shortcuts. As we have already shipped with ctrl+shift+` removing that didn't look like a good idea, so maintained both.

abose included the following code: https://github.com/adobe/brackets/pull/12243/commits

core-ai-bot commented 3 years ago

Comment by abose Thursday Feb 25, 2016 at 06:38 GMT

@swmitra@petetnt

core-ai-bot commented 3 years ago

Comment by petetnt Thursday Feb 25, 2016 at 07:04 GMT

Confirmed to work on non-US keyboard under Windows 10, LGMT with small language nitpick :+1:

core-ai-bot commented 3 years ago

Comment by swmitra Thursday Feb 25, 2016 at 08:37 GMT

LGTM :+1:

core-ai-bot commented 3 years ago

Comment by abose Thursday Feb 25, 2016 at 08:45 GMT

Thanks@petetnt looks like the PR got merged for the doc change :sweat_smile: .

core-ai-bot commented 3 years ago

Comment by petetnt Thursday Feb 25, 2016 at 08:47 GMT

No probs :joy_cat: