search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [CEF 2623] Upgrade to latest CEF #10633

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by nethip Wednesday May 11, 2016 at 18:49 GMT Originally opened as https://github.com/adobe/brackets/pull/12415

With latest CEF, quick open is not showing the results as opacity was set to 0. So removed opacity for .quick-search-container

This is required for updating shell APIt Related PR :https://github.com/adobe/brackets-shell/pull/544

nethip included the following code: https://github.com/adobe/brackets/pull/12415/commits

core-ai-bot commented 3 years ago

Comment by nethip Wednesday May 11, 2016 at 18:49 GMT

@swmitra Could you have a look at this PR?

core-ai-bot commented 3 years ago

Comment by nethip Wednesday May 11, 2016 at 18:59 GMT

@MarcelGerber@ingorichter@peterflynn Would you guys be able to review this PR?

core-ai-bot commented 3 years ago

Comment by Denisov21 Wednesday May 11, 2016 at 19:37 GMT

:+1: Good for me!

core-ai-bot commented 3 years ago

Comment by MarcelGerber Thursday May 12, 2016 at 16:40 GMT

@nethip I have altered this PR by actually fixing the .animation LESS mixin (which was the reason why Quick Open failed), fixing it in other locations, too, and adding opacity: 0 back.

core-ai-bot commented 3 years ago

Comment by nethip Thursday May 12, 2016 at 16:45 GMT

@MarcelGerber thanks for fixing the actual problem.

core-ai-bot commented 3 years ago

Comment by swmitra Friday May 13, 2016 at 12:53 GMT

LGTM. Kudos to@nethip :+1: for this PR and the related PR in brackets-shell. Great job by@MarcelGerber by providing quick fix for the quick open issue :+1: Merging...