search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Use opn instead of open. #10779

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ficristo Tuesday Aug 02, 2016 at 17:54 GMT Originally opened as https://github.com/adobe/brackets/pull/12641

Installed with node@3 and npm install --production

ficristo included the following code: https://github.com/adobe/brackets/pull/12641/commits

core-ai-bot commented 3 years ago

Comment by petetnt Wednesday Aug 03, 2016 at 20:40 GMT

This line: https://github.com/adobe/brackets/blob/656a0ee1d9889e853a77a4d9b12b9a82e6f86c55/src/LiveDevelopment/MultiBrowserImpl/launchers/node/LauncherDomain.js#L29 needs to be changed to var open = require("opn"); too right?

core-ai-bot commented 3 years ago

Comment by ficristo Wednesday Aug 03, 2016 at 21:57 GMT

@petetnt of course... fixed.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday Aug 09, 2016 at 06:39 GMT

I think we need some sort of https://github.com/adobe/brackets-shell/pull/505/files for this one, too, so it works when installed with the .deb file. LGTM otherwise.

core-ai-bot commented 3 years ago

Comment by ficristo Wednesday Aug 10, 2016 at 10:54 GMT

we need some sort of

I guess I learn something every day

I've opened two PR one for maste and one for linux-1547 branch on brackets-shell

core-ai-bot commented 3 years ago

Comment by MarcelGerber Wednesday Aug 10, 2016 at 14:57 GMT

LGTM. Also tested this with an installer build on Linux to make sure it works. Merging.