Open core-ai-bot opened 3 years ago
Comment by petetnt
Wednesday Aug 03, 2016 at 20:40 GMT
This line: https://github.com/adobe/brackets/blob/656a0ee1d9889e853a77a4d9b12b9a82e6f86c55/src/LiveDevelopment/MultiBrowserImpl/launchers/node/LauncherDomain.js#L29 needs to be changed to var open = require("opn");
too right?
Comment by MarcelGerber
Tuesday Aug 09, 2016 at 06:39 GMT
I think we need some sort of https://github.com/adobe/brackets-shell/pull/505/files for this one, too, so it works when installed with the .deb file. LGTM otherwise.
Comment by ficristo
Wednesday Aug 10, 2016 at 10:54 GMT
we need some sort of
I guess I learn something every day
I've opened two PR one for maste and one for linux-1547 branch on brackets-shell
Comment by MarcelGerber
Wednesday Aug 10, 2016 at 14:57 GMT
LGTM. Also tested this with an installer build on Linux to make sure it works. Merging.
Installed with node@3 and npm install --production
ficristo included the following code: https://github.com/adobe/brackets/pull/12641/commits