[CLOSED] CSS: remove unneeded prefixes, add standard properties, remove `px` from 0s

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] CSS: remove unneeded prefixes, add standard properties, remove `px` from 0s #10785

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by valtlai Thursday Aug 04, 2016 at 01:03 GMT Originally opened as https://github.com/adobe/brackets/pull/12648

Add standard transform, filter, animation and width: max-content
Remove prefixed border-radius, box-shadow, transition, linear-gradient(), box-sizing, text-overflow, flex-direction and display: flex
Remove prefixed transform from standard @keyframes
Remove px from zero values

(Replaces #12163)

valtlai included the following code: https://github.com/adobe/brackets/pull/12648/commits

core-ai-bot commented 3 years ago

Comment by MarcelGerber Thursday Aug 04, 2016 at 09:08 GMT

Am I right in the assumption that you have had your GitHub name changed? In that case, you need to sign the CLA again (http://dev.brackets.io/brackets-contributor-license-agreement.html).

core-ai-bot commented 3 years ago

Comment by valtlai Thursday Aug 04, 2016 at 12:01 GMT

@MarcelGerber, done.

core-ai-bot commented 3 years ago

Comment by valtlai Friday Aug 05, 2016 at 00:27 GMT

What is the Chromium version on Linux now? Maybe prefixed transform, animation and @keyframes can be removed too.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Friday Aug 05, 2016 at 00:50 GMT

Unfortunately, it's still ~ Chromium 29 on Linux builds.

For some reason, the CLA check still fails, even after re-running the Travis build multiple times. re you sure you have provided the correct username in the form?

core-ai-bot commented 3 years ago

Comment by valtlai Friday Aug 05, 2016 at 00:59 GMT

@MarcelGerber I think I did.

However, check details contains "x-ratelimit-limit":"60","x-ratelimit-remaining":"0","x-ratelimit-reset":"1470359670"

Edit: and "message":"API rate limit exceeded for 52.22.60.255. too.

core-ai-bot commented 3 years ago

Comment by ficristo Sunday Aug 07, 2016 at 18:20 GMT

Still LGTM, but I prefer if someone else could do the last check.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Sunday Aug 07, 2016 at 21:41 GMT

I would like to have this briefly tested on Linux as well, at least looking out for obvious regressions. If no one else offers to take over this task, I can probably revive my Linux Mint VM :)

core-ai-bot commented 3 years ago

Comment by ficristo Monday Aug 08, 2016 at 12:27 GMT

I gave a try on a VM with Ubuntu 16.04 and didn't notice anything obviously wrong.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Monday Aug 08, 2016 at 15:38 GMT

Going for it in that case. Thank you all! Merging.