search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] MultiBrowser Live Preview: Fix cases where url()s in CSS weren't resolved correctly #10828

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by MarcelGerber Monday Aug 22, 2016 at 23:47 GMT Originally opened as https://github.com/adobe/brackets/pull/12705

Fixes #11076 and #11936.

In cases where the referenced CSS files aren't in the same folder the HTML file is in, we had the problem that after altering the CSS, the url()s referenced in there (think background-image, @import, which the two issues above are about) were relative to the HTML instead of relative to the CSS. My attempt at fixing this issue is to make any relative url() absolute (where the absolute path is the CSS file), that is, for example, converting a background: url(chevron.png); to a background: url(http://127.0.0.1:port/sub/chevron.png)

cc@busykai

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/12705/commits

core-ai-bot commented 3 years ago

Comment by zaggino Thursday Aug 25, 2016 at 22:20 GMT

This is really nice and clean PR, LGTM

core-ai-bot commented 3 years ago

Comment by MarcelGerber Thursday Aug 25, 2016 at 22:23 GMT

Thanks@zaggino!