search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Quick Open JS: can't access second function with same name #1101

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Friday Jun 22, 2012 at 04:34 GMT Originally opened as https://github.com/adobe/brackets/issues/1109

  1. Open codemirror.js
  2. Ctrl+T
  3. Type "clipTo"
  4. Arrow down to each result in turn

Result: Both results take you to the same spot, line 2630.

Expected: Since there are two results, they should go to two different declarations. (There really are two different declarations: the second one is on line 2657).

This bug does not affect Quick Edit (inline editor) -- that correctly shows the two results with their different line numbers and different method bodies.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Jun 22, 2012 at 04:34 GMT

@tvoliter: I have a branch with some Quick Open cleanup that might help with this. I'll check after the sprint closes down & reassign to myself if so.

core-ai-bot commented 3 years ago

Comment by pthiess Friday Jun 22, 2012 at 18:07 GMT

Reviewed - not a blocking issue.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Sep 05, 2012 at 07:36 GMT

Turns out it's not fixed by my code cleanup -- those changes are necessary but not sufficient. To fully fix this, the JS Quick Open code will need to change from storing ambiguous strings as the search results, to storing something unambiguous like text offsets.

Note: the same bug also occurs for CSS Quick Open (duplicate selectors).

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Oct 17, 2012 at 18:24 GMT

Oops -- closing. The fix for this landed a couple weeks ago.