Open core-ai-bot opened 3 years ago
core-ai-bot
commented
3 years ago 
Why not use requirejs to create some logical mapping between the node_modules and thirdparty folders?
I think@petetnt has done that in https://github.com/adobe/brackets/issues/12006
If we go on this route we probably need to do something for distribution. (I don't remember exactly but I think we don't copy the node_modules over there)
core-ai-bot
commented
3 years ago 
Not sure how to do any logical mapping here, but happy to learn. We could use a separate package.json file inside the src folder for production dependencies. That's how brackets-electron does it and that's how electron authors recommend electron projects to be done.
core-ai-bot
commented
3 years ago
The other idea I had in mind was exactly putting a package.json inside the src folder.
Both cases seems better to me.
For the logical mapping@petetnt knows more.
core-ai-bot
commented
3 years ago 
One can use relative mapping with ../node_modules/... for the requirejs config so you can use deps from the root folder: https://github.com/petetnt/brackets/blob/petetnt/poc-thirdparty-with-npm/src/main.js#L68. Not sure if that works in browser though.
core-ai-bot
commented
3 years ago
Closing in favor of https://github.com/adobe/brackets/pull/12972
PR for https://github.com/adobe/brackets/issues/12937
zaggino included the following code: https://github.com/adobe/brackets/pull/12940/commits