search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix for #12970: Non-default languages and user preferences bug #11040

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by haslam22 Tuesday Dec 13, 2016 at 20:05 GMT Originally opened as https://github.com/adobe/brackets/pull/12979

This fixes #12970 by removing invalid mappings from the preference state, occurring when a language has not been loaded yet. When the language is eventually loaded, an _updateFromPrefs call restores the preferences.

haslam22 included the following code: https://github.com/adobe/brackets/pull/12979/commits

core-ai-bot commented 3 years ago

Comment by zaggino Wednesday Dec 14, 2016 at 23:22 GMT

@Athorcis can you review and verify this fixes #12970 ? I've tried this but it doesn't seem to resolve the steps described in your issue.

core-ai-bot commented 3 years ago

Comment by Athorcis Thursday Dec 15, 2016 at 11:49 GMT

@zaggino i'll try and i'll let you know

core-ai-bot commented 3 years ago

Comment by haslam22 Thursday Dec 15, 2016 at 21:13 GMT

@zaggino Just tested it again on Windows & Ubuntu with the latest master and it works fine with the steps described in the issue. I may have missed something so I'll take another look later

core-ai-bot commented 3 years ago

Comment by haslam22 Friday Dec 16, 2016 at 19:14 GMT

Reset the branch, I think I messed up my fork somehow. Should work fine now.

core-ai-bot commented 3 years ago

Comment by haslam22 Saturday Dec 17, 2016 at 04:55 GMT

I was able to produce a fix for the steps in the issue but I didn't try using .twig files (issue describes step 2 as any file type that's not supported). I can now see that overriding .twig is a specific scenario that doesn't work, but all other extensions are fine.

So I've added a fix for this as well. You can now override .twig files and make it work with the Twig language.

Apologies for any spam.

core-ai-bot commented 3 years ago

Comment by Athorcis Saturday Dec 17, 2016 at 14:35 GMT

Thx for your work, i don't have the bug anymore

core-ai-bot commented 3 years ago

Comment by zaggino Tuesday Dec 20, 2016 at 07:54 GMT

@haslam22 let me know when you think it's ready, I see you're still adding some commits.

core-ai-bot commented 3 years ago

Comment by haslam22 Tuesday Dec 20, 2016 at 11:05 GMT

@zaggino All finished now, thanks for taking the time to review.

core-ai-bot commented 3 years ago

Comment by zaggino Tuesday Dec 20, 2016 at 22:39 GMT

reviewed & merged, thanks@haslam22 !

core-ai-bot commented 3 years ago

Comment by petetnt Thursday Dec 22, 2016 at 08:39 GMT

Nice job@haslam22 👍