search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Custom font is ignored #11213

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by thany Friday Mar 24, 2017 at 17:12 GMT Originally opened as https://github.com/adobe/brackets/issues/13221

Prerequisites

Description

A custom font set in View->Themes is ignored.

Steps to Reproduce

  1. Open Brackets
  2. View->Themes
  3. Set any other font. In my case, Fira Code, so: Fira Code, FiraCode, 'SourceCodePro-Medium', ＭＳ ゴシック, 'MS Gothic', monospace

Expected behavior: Custom font should be displayed in the editor.

Actual behavior: Custom font is set, but only once, after committing the setting. After zooming in/out, after a restart, or a reload, the default font is displayed again.

Versions

Brackets 1.9 Windows 10

This is a regression from 1.8, where setting a custom font worked just fine.

core-ai-bot commented 3 years ago

Comment by zmyjs Friday Mar 24, 2017 at 17:36 GMT

‘I’ve been through the same situation!

core-ai-bot commented 3 years ago

Comment by prasadmudedla Friday Mar 24, 2017 at 18:29 GMT

same situation... tried changing the defaultPreferneces.json.... Still no luck...

core-ai-bot commented 3 years ago

Comment by clementi Friday Mar 24, 2017 at 21:26 GMT

I'm seeing this also. Windows 7 and Windows 10.

core-ai-bot commented 3 years ago

Comment by guillecro Sunday Mar 26, 2017 at 13:39 GMT

This issue is already posted here, https://github.com/adobe/brackets/issues/13205

Its not working even in Ubuntu (in my case Ubuntu 16.04 LTS x64)

core-ai-bot commented 3 years ago

Comment by thany Monday Mar 27, 2017 at 08:30 GMT

That appears to be a different issue, as it also reports the problem in 1.8. This particular case is a regression from 1.8, meaning the feature worked fine in 1.8, but it broke as of 1.9.

core-ai-bot commented 3 years ago

Comment by gxnie Friday Mar 31, 2017 at 06:46 GMT

I have modified the brackets.min.css.

core-ai-bot commented 3 years ago

Comment by thany Friday Mar 31, 2017 at 08:55 GMT

Can this please be fixed with a maintenance update?

It happens too often that we need to wait 3 months or longer, for an issue to get solved in the next release. And any new release may introduce other breaking bugs, causing us to have to wait even longer.

core-ai-bot commented 3 years ago

Comment by guillecro Friday Mar 31, 2017 at 11:42 GMT

Can this please be fixed with a maintenance update?

I +1 this comment. Its such annoying bug..

core-ai-bot commented 3 years ago

Comment by jpdupont Friday Mar 31, 2017 at 16:11 GMT

+1

core-ai-bot commented 3 years ago

Comment by swmitra Saturday Apr 01, 2017 at 09:52 GMT

@thany We are working on this issue and hopefully have a fix by next week. Once the fix is in, we will trigger a pre-release which would be available under Brackets GitHub releases.

core-ai-bot commented 3 years ago

Comment by vahid-sanati Sunday Apr 02, 2017 at 15:26 GMT

I have this bug too. When I change the font in preferences, the font changes. But after restarting brackets it shows with default font.

core-ai-bot commented 3 years ago

Comment by swmitra Monday Apr 10, 2017 at 05:25 GMT

Closing this as fixed by #13279 and available as part of 1.10 pre-release 1 build https://github.com/adobe/brackets/releases/tag/release-1.10-prerelease-1

core-ai-bot commented 3 years ago

Comment by thany Tuesday May 23, 2017 at 09:44 GMT

I just noticed 1.9 is still up as the latest release, even though this bug is still in there, supposedly. Why aren't you releasing this 1.10-prerelease as a maintenance update to 1.9? You can call it 1.9.1 or something.