search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Replaced English comments with Japanese translations #11275

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by Blackweda Friday Apr 21, 2017 at 11:51 GMT Originally opened as https://github.com/adobe/brackets/pull/13320

This is a PR to fix issue #12880

This issue is fixing the comment sections for the French and Japanese translations so that the comments are in those respective languages, and not in English.

I looked over both:

samples/fr/Premiers pas samples/ja/Getting Started

The French translation had already been done, so I worked out the translations for the Japanese and made the changes to the comment sections. If a more accurate translation comes up, please let me know.

This should close the issue if everyone is satisfied with the translations.

Here are the translation equivalents:

自分のファイルで始めましょう Let’s start with your own file

Brackets のは何ですか What is Brackets?

ご意見をお聞かせ Tell us your opinion

HTML、CSSとJavaScriptとの関係 Relationship between HTML, CSS and JavaScript

<3とJAVASCRIPTで作成 Created with <3 and Javascript

ライブ プレビュー Live preview

Blackweda included the following code: https://github.com/adobe/brackets/pull/13320/commits

core-ai-bot commented 2 years ago

Comment by Blackweda Friday Apr 21, 2017 at 17:35 GMT

I had a Japanese friend look over the translations. She only recommended a slight change to two of them because they sounded better to her when she read it that way. Everything else was fine with her.

core-ai-bot commented 2 years ago

Comment by ficristo Friday Apr 21, 2017 at 18:24 GMT

Usually Japanese translations are done by the Adobe team. I'm not sure about the samples... @swmitra@saurabh95 ?

@Blackweda you should revert all the changes to the indentation of the closing -->.

core-ai-bot commented 2 years ago

Comment by saurabh95 Friday Apr 21, 2017 at 18:31 GMT

Yeah generally Adobe ALF team does translations, but we can definitely get this reviewed by them(since they would be having more context), and get it merged. @VibhaMalhotra@ArturOledzki@pantkowiak@rajjain Could you please review this?

core-ai-bot commented 2 years ago

Comment by Blackweda Saturday Apr 22, 2017 at 09:02 GMT

sorry@ficristo , what are you saying about indentation of the closing --> ?? I didn't move anything except change the wording, the placement is still the same from beforehand.

core-ai-bot commented 2 years ago

Comment by ficristo Saturday Apr 22, 2017 at 12:48 GMT

If you look at the GitHub interface you can notice some changes to lines with the closing -->. It seems you accindentally convert some spacing to tabs, please undo that.

core-ai-bot commented 2 years ago

Comment by Blackweda Saturday Apr 22, 2017 at 22:19 GMT

Sorry I had deleted my forked version.. I have to redo all this.