search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Changed WebPlatform License to MDN License and respective strings #11354

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by saurabh95 Thursday Jun 15, 2017 at 18:58 GMT Originally opened as https://github.com/adobe/brackets/pull/13447

We still need to get translations for some languages.

saurabh95 included the following code: https://github.com/adobe/brackets/pull/13447/commits

core-ai-bot commented 3 years ago

Comment by ficristo Thursday Jun 15, 2017 at 19:15 GMT

I skimmed through the changes and they seems good. But I noticed the following things (at the left it is the locale):

core-ai-bot commented 3 years ago

Comment by saurabh95 Friday Jun 16, 2017 at 05:42 GMT

The above mentioned locales with no urls.js there is no getting started page defined in sample, so probably this might be the reason of not creating the urls.js

core-ai-bot commented 3 years ago

Comment by ficristo Saturday Jun 17, 2017 at 12:58 GMT

Yeah, what I was trying to say, if you need the text translated everywhere those languages will not be.

core-ai-bot commented 3 years ago

Comment by saurabh95 Monday Jun 19, 2017 at 05:30 GMT

@ficristo I just did replace of Web Platform to MDN, there are some languages which got missed out, since I am not an expert in those languages so I kept them as it is. Once this is merged we can ask Adobe Localization team to verify translations for French and Japanese and the rest of the languages can be verified/corrected by community over time.