search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fix lgtm alerts #11375

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by xiemaisi Monday Jun 26, 2017 at 11:29 GMT Originally opened as https://github.com/adobe/brackets/pull/13483

This fixes a few minor issues found by lgtm; for more details see https://lgtm.com/projects/g/adobe/brackets/alerts/.

The fixes in the first three commits are fairly obvious, the last two commits involve some educated guessing as to the intended semantics of the code involved.

xiemaisi included the following code: https://github.com/adobe/brackets/pull/13483/commits

core-ai-bot commented 3 years ago

Comment by xiemaisi Tuesday Jun 27, 2017 at 06:56 GMT

I've removed the last two commits with the less obvious fixes; I'll put them up as a separate PR.

core-ai-bot commented 3 years ago

Comment by xiemaisi Thursday Jun 29, 2017 at 11:46 GMT

@petetnt, does this look safer now?