brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Update CSS property hints #11667

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by valtlai Friday Jan 05, 2018 at 20:29 GMT Originally opened as https://github.com/adobe/brackets/pull/14014


Reordered properties and their values alphabetically.

Added CSS-wide keywords – inherit, initial, revert, unset – to the end of arrays.

Added properties * `backdrop-filter` * `background-position-x` * `background-position-y` * `block-size` * `border-block-end-color` * `border-block-end-style` * `border-block-end-width` * `border-block-end` * `border-block-start-color` * `border-block-start-style` * `border-block-start-width` * `border-block-start` * `border-inline-end-color` * `border-inline-end-style` * `border-inline-end-width` * `border-inline-end` * `border-inline-start-color` * `border-inline-start-style` * `border-inline-start-width` * `border-inline-start` * `clip-path` * `clip-rule` * `contain` * `font-variation-settings` * `image-rendering` * `inline-size` * `justify-items` * `justify-self` * `margin-block-end` * `margin-block-start` * `margin-inline-end` * `margin-inline-start` * `max-block-size` * `max-inline-size` * `min-block-size` * `min-inline-size` * `offset-distance` * `offset-path` * `offset-rotate` * `offset` * `overflow-anchor` * `overflow-wrap` * `overscroll-behavior-x` * `overscroll-behavior-y` * `overscroll-behavior` * `padding-block-end` * `padding-block-start` * `padding-inline-end` * `padding-inline-start` * `place-content` * `place-items` * `place-self` * `scroll-margin-block-end` * `scroll-margin-block-start` * `scroll-margin-block` * `scroll-margin-bottom` * `scroll-margin-inline-end` * `scroll-margin-inline-start` * `scroll-margin-inline` * `scroll-margin-left` * `scroll-margin-right` * `scroll-margin-top` * `scroll-margin` * `scroll-padding-block-end` * `scroll-padding-block-start` * `scroll-padding-block` * `scroll-padding-bottom` * `scroll-padding-inline-end` * `scroll-padding-inline-start` * `scroll-padding-inline` * `scroll-padding-left` * `scroll-padding-right` * `scroll-padding-top` * `scroll-padding` * `scroll-snap-align` * `scroll-snap-stop` * `scroll-snap-type` * `speak` * `text-combine-upright` * `text-justify` * `text-orientation` * `text-size-adjust` * `touch-action` * `transform-box` * `writing-mode`
Updated value lists | Property | Added values | Removed values | | --- | --- | --- | | `align-content` | `baseline`
`end`
`first`
`last`
`normal`
`safe`
`space-evenly`
`start`
`unsafe` | `align-items` | `end`
`first`
`last`
`normal`
`safe`
`self-end`
`self-start`
`start`
`unsafe` | `align-self` | `last`
`normal`
`safe`
`self-end`
`self-start`
`start`
`unsafe` | `box-shadow` | `inset` | `clear` | `inline-end`
`inline-start` | `clip` | `rect()` | `float` | `inline-end`
`inline-start` | `image-orientation` | `flip`
`from-image` | `justify-content` | `end`
`left`
`normal`
`right`
`safe`
`space-evenly`
`start`
`stretch`
`unsafe` | `text-align` | `end`
`start` | `text-align-last` | `end`
`start` | `unicode-bidi` | `isolate`
`isolate-override`
`plaintext` | `background-image` | `conic-gradient()`
`cross-fade()`
`none`
`repeating-conic-gradient()` | `break-after`
`break-before` | `recto`
`verso` | `always` | `height`
`width`
`max-height`
`min-height` | `fit-content`
`max-content`
`min-content` | `filter` | | `custom()` | `font-family` | `system-ui` | `font-synthesis` | `small-caps` | `min-height`
`min-width` | `auto`
`fit-content`
`max-content`
`min-content`
Removed properties (Deprecated, replaced with `break-*`) * `region-break-after` * `region-break-before` * `region-break-inside`.

valtlai included the following code: https://github.com/adobe/brackets/pull/14014/commits

core-ai-bot commented 3 years ago

Comment by ficristo Saturday Jan 13, 2018 at 16:57 GMT


It seems to me that many rules you are adding aren't implemented by the browser vendors, at least according to https://caniuse.com I don't know what is the rule at Adobe, but I'm not sure if they are really useful if no one can use them.

@valtlai@petetnt what do you think of not add inherit, initial, revert, unset in the configuration, and instead look a way of add them directly in the code? It is easy to mistype or forget them if they are in the config.

Also please take a look at the tests.

core-ai-bot commented 3 years ago

Comment by valtlai Sunday Jan 14, 2018 at 12:04 GMT


@ficristo Yeah, we should add the global values dynamically.

Something like this before any use of properties would work:

let globalValues = ["inherit", "initial", "revert", "unset"];

for (let values of Object.values(properties)) {
    values.push(...globalValues);
}
core-ai-bot commented 3 years ago

Comment by nethip Wednesday Feb 07, 2018 at 06:39 GMT


@valtlai Great work! Could you site the url (like mozilla webdocs e.t.c.) from which you have updated the hints?

core-ai-bot commented 3 years ago

Comment by ficristo Wednesday Feb 07, 2018 at 20:52 GMT


@valtlai for the global values here seems a good place. Could you check? If it does work for you, could you open a PR with only that (and related tests fixed)?

core-ai-bot commented 3 years ago

Comment by valtlai Wednesday Apr 18, 2018 at 19:53 GMT


I’ll close this now and make new, smaller PRs later.