search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Bringing in ImmutableJS 3.8.2 #11755

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by vickramdhawal Thursday Mar 22, 2018 at 10:24 GMT Originally opened as https://github.com/adobe/brackets/pull/14168

Bringing in ImmutableJS 3.8.2 which is release under MIT license. Source of immutableJS https://github.com/facebook/immutable-js/releases/tag/v3.8.2. Also updating the gitignore file to exclude node_modules inside src/JSUtils

vickramdhawal included the following code: https://github.com/adobe/brackets/pull/14168/commits

core-ai-bot commented 3 years ago

Comment by nethip Thursday Mar 22, 2018 at 10:49 GMT

Thanks for the PR@vickramdhawal :+1:

Did you get a chance to run unit tests?

core-ai-bot commented 3 years ago

Comment by nethip Thursday Mar 22, 2018 at 10:53 GMT

Also looks like CLA has not been signed that is why the travis tests are failing. Can you signup using this link? Please sign the CLA here http://dev.brackets.io/brackets-contributor-license-agreement.html.

core-ai-bot commented 3 years ago

Comment by vickramdhawal Thursday Mar 22, 2018 at 10:58 GMT

I've signed up now. I did run all tests, but have to bear with multiple dialogs to get it to completion. Will update once its done.

core-ai-bot commented 3 years ago

Comment by nethip Thursday Mar 22, 2018 at 11:47 GMT

Thanks@vickramdhawal I have restarted the build.

core-ai-bot commented 3 years ago

Comment by nethip Thursday Mar 22, 2018 at 11:54 GMT

You can disable the dialog popups by returning from the below function. We will have to figure out other means of handling the dialog popups. https://github.com/adobe/brackets/blob/master/src/document/DocumentCommandHandlers.js#L1727

core-ai-bot commented 3 years ago

Comment by vickramdhawal Thursday Mar 22, 2018 at 12:42 GMT

immutableJS is used only by the FileTreeView & the FileTreeViewModel and the tests are passing for both. Unit tests are also passing except for the ones already failing on master.

core-ai-bot commented 3 years ago

Comment by swmitra Friday Mar 23, 2018 at 06:58 GMT

Good work@vickramdhawal.