search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Base Level TouchBar Support #11790

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jordanwolff Monday Apr 16, 2018 at 07:55 GMT Originally opened as https://github.com/adobe/brackets/pull/14221

An extension for the Brackets app. The main.js file implements base level classes that can be utilized to implement TouchBar for Apple MacBook Pro computers. The code has been written with the goal of being easily extensible by other developers. I created this in response to Issue #12996. The Brackets app needs features like this one in order to keep pace with other text editing tools. I hope its well received and would appreciate any feedback and ideas.

Attached (below) is the goal I had for what the end implementation may look like. Thank you all!

touchbar-proto 001

jordanwolff included the following code: https://github.com/adobe/brackets/pull/14221/commits

core-ai-bot commented 3 years ago

Comment by bellarosedc Tuesday Apr 17, 2018 at 00:45 GMT

Consistent and clear naming convention and structure throughout the code. Comments were very helpful, especially the RMEs for each function. I didn't notice any bugs. All questions I had in regards to code design were easily justified.

core-ai-bot commented 3 years ago

Comment by swmitra Tuesday May 15, 2018 at 14:15 GMT

@jordanwolff The change set suggests that this is just a feature mock and not the actual feature implementation. Closing this PR now and will look forward for the actual feature implementation from you, probably once we have a CEF shell that provides support for TouchBar 👍

core-ai-bot commented 3 years ago

Comment by narcarsiss Tuesday Jun 19, 2018 at 06:33 GMT

Do we have any progress on this? would like to see a feature set where in split view, you can long hold the touch bar "tab" to move tabs to either side. [ tab | tab ].

Colour Picker; with ability to set Design defaults, or read SASS colour variables. Default commands, like shortcuts, (undo, redo, save, live-load), support for brackets-git, emmet.

Regards.