[CLOSED] InApp Notifications

[core-ai-bot]

Issue by swmitra Monday Apr 22, 2019 at 16:26 GMT Originally opened as https://github.com/adobe/brackets/pull/14715

---

This PR adds the required infrastructure to display App notifications created by Brackets publisher with the ability to filter applicability of the notifications based on multiple parameters. A sample notifications file (localized) hosted from S3 would look like -

{
    "notifications": [
        {
            "sequence": "1555874975721",
            "silent": false,
            "filters": {
                "platforms": ["OSX"],
                "version": "1.14",
                "locales": ["en"],
                "builds": [],
                "extensions": [],
                "lastUsed": ""
            },
            "html": "<div><span>Web development and design trends are changing at a rapid pace. We want to hear how new paradigms and tools are impacting you and the way you work!</span><a id='banner-button' href='https://adobe.ly/bracketsiosurvey'>Take the Brackets Survey</a></div>",
            "actionables": "#banner-button",
            "expiry" : "1556044200000"
        }
    ]
}

---

swmitra included the following code: https://github.com/adobe/brackets/pull/14715/commits

[core-ai-bot]

Comment by swmitra Tuesday Apr 23, 2019 at 17:17 GMT

---

@boopeshmahendran and@shubhsnov Thanks a ton for reviewing this PR minutely under short notice 💯 Addressed all comments now. @shubhsnov Please test it once more whenever possible.

[core-ai-bot]

Comment by shubhsnov Thursday Apr 25, 2019 at 08:59 GMT

---

LGTM 👍 Tested with multiple platforms, versions etc. Everything is working fine. With this, we can target notifications in the future. Thanks,@swmitra for this brilliant contribution.