search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] If there is no port number given for remote debugging, it is showing as "0" #12069

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ranjithagp Tuesday Nov 19, 2019 at 09:32 GMT Originally opened as https://github.com/adobe/brackets/issues/14973

Steps to Reproduce;

1.Open console in Brackets application. 2.Call a function without giving any port number : appshell.app.getRemoteDebuggingPort(function(err,arg){console.log(arg);})

Expected behavior: It should return something which is not a valid port number (ex : NULL or '-1')

Actual behavior: Its returning "0" which is a valid port number

Note : Port numbers range from 0 to 65535 (anything within this range will be a valid port number including "0". Brackets vesrion: 1.14.1

Platform: Win and Mac

@yprasad1@narayani28@jha-g

core-ai-bot commented 3 years ago

Comment by jha-g Friday Nov 22, 2019 at 10:02 GMT

@ranjithagp, Fixed the issue, lack of remote-debugging-port is denoted by null now.

Screen Shot 2019-11-22 at 3 29 50 PM
core-ai-bot commented 3 years ago

Comment by ranjithagp Friday Nov 29, 2019 at 12:49 GMT

Validated, Not reproducible with the Brackets 1.14.1-17752 on Mac ,Win and Ubuntu. Hence closing the bug.