Quick View does not detect when bottom panel hides code being previewed

[core-ai-bot]

Issue by redmunds Wednesday Apr 24, 2013 at 18:52 GMT Originally opened as https://github.com/adobe/brackets/issues/3596

---

1. Open QuickView/unittest.js
2. Find a line that triggers quick view (e.g. 117: "rgb(255,0,0)") and make it bottom line in editor
3. Turn on JSLint
4. Make an edit that will cause a JSLint error, but do not save yet
5. Hover mouse over code that triggers popover
6. Ctrl-S to save

Results Bottom panel covers code that triggered popover, but popover is still displayed

Expected Popover is hidden when code cannot be seen in editor

Using the builtin JSLint panel makes this look contrived, but there are many other ways to popup bottom panel (mostly with extensions), so I think this is a valid bug.

[core-ai-bot]

Comment by RaymondLim Wednesday Apr 24, 2013 at 19:06 GMT

---

We should have caught this in our "scroll" event listener.

[core-ai-bot]

Comment by peterflynn Wednesday Apr 24, 2013 at 19:25 GMT

---

@RaymondLim not necessarily: showing/hiding a bottom panel typically doesn't shift the top of the scroll viewport at all.

I wonder if this should wait until more generalized panel-tracking APIs land (see threads in #3371 and #2015). Is it a must-fix for this sprint?

[core-ai-bot]

Comment by RaymondLim Wednesday Apr 24, 2013 at 19:30 GMT

---

I tried with side bar, it does trigger "scroll" event.

Actually, it does hide preview via mouse move event.

[core-ai-bot]

Comment by gruehle Wednesday Apr 24, 2013 at 19:30 GMT

---

Seems low priority to me. I'd like to wait until we have the more generalized panel-tracking API.

[core-ai-bot]

Comment by peterflynn Wednesday Apr 24, 2013 at 23:38 GMT

---

Assigning to me to go with the other panel management issues

[core-ai-bot]

Comment by gruehle Thursday May 02, 2013 at 20:36 GMT

---

Reviewed