search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

JavaScript Jump To Definition Ctrl+J/Cmd+J not mentioned in Right-Click Menu #12286

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by pfarland Thursday May 16, 2013 at 20:40 GMT Originally opened as https://github.com/adobe/brackets/issues/3860

In any *.js JavaScript source file, right click to see the context menu show:

Quick Edit - Cmd+E Quick Docs - Cmd+K Select All - Cmd+A

It should also show:

Jump To Definition - Cmd+J

core-ai-bot commented 3 years ago

Comment by jeffkenton Monday May 20, 2013 at 16:55 GMT

I'm looking a this one. (There's some problem actually assigning it to me, but it's mine.)

core-ai-bot commented 3 years ago

Comment by peterflynn Monday May 20, 2013 at 18:20 GMT

Reviewed.

@adrocknaphobia One issue here is that the menu contents aren't yet selective based on file type. So this would show up in all files, even though it does nothing if you're not in JS code. Should we hold off until we have a better story for truly context-sensitive menus?

Another related point -- Jump to Definition is currently hardcoded to go directly to the JS extension. It's not pluggable in a language-related way, so e.g. a PHP or TypeScript extension would have to add its own separate menu item with the same functionality. We should consider converting the menu item into a more generic extensible hook at some point.

core-ai-bot commented 3 years ago

Comment by pfarland Monday May 20, 2013 at 18:52 GMT

The menu contents need to be selective based on file type, so we'll hold off on the right click menu - but the hook for other languages sounds useful to address as it shouldn't be tied to JS exclusively.

core-ai-bot commented 3 years ago

Comment by jeffkenton Monday May 20, 2013 at 20:46 GMT

Both the right-click context menu addition and the Jump-To-Definition navigation menu issue can probably be solved at the same time, using the same technique used by QuickEdit, i.e., registering separate provider functions to handle the various cases.

core-ai-bot commented 3 years ago

Comment by jeffkenton Wednesday May 29, 2013 at 14:14 GMT

I have just made a pull request which has Jump-To-Definition added to the right-click menu. It's only one line of code, so we can comment it out at will.

To elaborate: to do this right, we'd want to check the file type (or selection type) every time we displayed the right-click menu, for jump-to-definition, quick edit, etc. We might also want to do the same for the top-level navigate menu. Is this what we plan to do?

core-ai-bot commented 3 years ago

Comment by redmunds Monday Mar 17, 2014 at 21:15 GMT

This issue is unassigned, so marking "Needs Review".

core-ai-bot commented 3 years ago

Comment by disshishkov Tuesday May 20, 2014 at 13:17 GMT

Guys, there is way to change hotkey from ctrl + j to f12?

core-ai-bot commented 3 years ago

Comment by dangoor Tuesday May 20, 2014 at 14:49 GMT

@disshishkov I haven't tried it, but there's a "Brackets Key Remapper" extension (see the extension manager in Brackets)

core-ai-bot commented 3 years ago

Comment by disshishkov Wednesday May 21, 2014 at 05:56 GMT

Thank you@dangoor , the mentioned by you extension works great