brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Mouse wheel on Windows should scroll an exact number of lines (respecting system preference) - NO version of Brackets has this yet #12508

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by thany Wednesday Jan 29, 2014 at 16:04 GMT Originally opened as https://github.com/adobe/brackets/issues/6684


My pc is set to scroll exactly 3 lines on each "click" of the scrollwheel (it's the default setting even). But Brackets manages to scroll further to about 6,5 lines in my case. This depends on the size of the editor font.

Scrolling by scrollwheel should always adhere to the system setting and should not vary by font size or line height.

(I'm also thinking if the scrolling machnism should snap to lines like almost all editors, rather than be smooth... I guess that one is personal preference)

Using Brackets 35 on Windows 7x 64.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Jan 29, 2014 at 18:30 GMT


Marking Win-only since Macs definitely don't do quantized scrolling

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Jan 29, 2014 at 18:32 GMT


@thany Does your mousewheel scroll the correct/desired amount in any of these places?

core-ai-bot commented 3 years ago

Comment by pthiess Friday Jan 31, 2014 at 17:57 GMT


@peterflynn , I'd call it a low priority.

core-ai-bot commented 3 years ago

Comment by thany Monday Feb 03, 2014 at 12:25 GMT


Sorry for the late reply.

Yes, all three scroll too fast. I suppose it's a problem (or missing feature, or an existing feature that's not used) in webkit/blink then. It seems this is one of the consequences of using a webbrowser engine to build a normal program. These engines tend to do things differently than the underlying OS.

Still, I do think this needs fixing. Personally I'm very much used to the scrolling speed I've set up.

Btw, doesn't this go for Mac as well? I'm sure you can perfectly well attach a mouse with a "clicky scrollwheel" to a mac. Then, something has to determine how much one "click" scrolls, right? On Windows, this setting is easily found; on Mac... No idea.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Feb 03, 2014 at 21:50 GMT


Marking 'move to backlog' due to the significant effort that would be involved, and marking CodeMirror since the fix would have to be down in the CM scrolling code (unless it's fixed in webkit instead)

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday Feb 04, 2014 at 15:07 GMT


I can repro that, too (Win 8.1, in browser and in Brackets itself), but Brackets (or WebKit, whatever) does not completely ignore that system setting: As you change it, the amount of scrolled lines changes, too.

Btw, both Internet Explorer and Firefox mind this setting, at least in the CodeMirror demo. Seems like this is really a WebKit problem.

core-ai-bot commented 3 years ago

Comment by bagusflyer Thursday Feb 13, 2014 at 08:39 GMT


My mac touchpad scrolling is also too fast. Almost can't use. Have to use arrow key to scroll down now.

core-ai-bot commented 3 years ago

Comment by thany Thursday Feb 13, 2014 at 11:32 GMT


SAPlayer, although it doesn't ignore the setting, it does implement it incorrectly. As Windows has this setting to explicitly scroll an X numer of lines, it shouldn't even be possible to scroll half a line.

It appears Brackets scrolls a certain number of pixels. IMO, a code editor should always scroll whole lines, unless using a device that allows smooth scrolling such as touch-input or a clickyless scrollwheel.

What's more, Ctrl+Arrow up/down does scroll whole lines at a time. So it must already be possible to do implement scrolling whole lines... What remains is to get from the OS how many lines.

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 13, 2014 at 19:03 GMT


My understanding is that the problem is that the actual delta values we get from mousewheel events in the browser are not consistent across browsers or platforms, so it's hard for CM to know how many lines to map a particular delta value to. I haven't looked into it in detail myself to figure out if there's a simple mapping we could just hardcode per browser, though.

core-ai-bot commented 3 years ago

Comment by thany Friday Feb 14, 2014 at 08:58 GMT


Why per browser? Brackets is based on the Blink engine, right? That's just one "browser".

That only leaves Windows and Mac to take into account as the two largest target platforms. Now, I'm not sure if there's a difference between versions of these OS'es, but as far as my understanding goes, Windows at least has been (fairly) consistent.

Linux is a whole different story of course...

core-ai-bot commented 3 years ago

Comment by njx Friday Feb 14, 2014 at 18:58 GMT


The core code editor in Brackets is a separate library called CodeMirror (https://github.com/marijnh/CodeMirror), which is what actually draws the text and handles things like scrolling. That's built to work across browsers, and it's the part that would need to be fixed to address this issue.

(Also, eventually we want Brackets to work in-browser as well.)

core-ai-bot commented 3 years ago

Comment by adammesa Sunday Feb 01, 2015 at 06:24 GMT


Any updates on this? I'm having this issue as well, except one click of my scroll seemingly moves my view port down 28 lines... making the code editor extremely unusable if I want to scroll with my mouse wheel... ctrl + arrows seems to be the only solution for me. :(

core-ai-bot commented 3 years ago

Comment by MarcelGerber Sunday Feb 01, 2015 at 13:19 GMT


The problem that got worse with Brackets 1.1 is tracked in https://github.com/adobe/brackets/issues/10214.

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Feb 02, 2015 at 21:54 GMT


Clarifying title to differentiate better from the regression in #10214

core-ai-bot commented 3 years ago

Comment by thany Tuesday Mar 03, 2015 at 09:50 GMT


Not fixed in 1.2. Why? This is a pretty serious, and blatanly obvious problem!

Could've been dead simple to just include a previous (working) version of CEM until they fix it on their end.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Mar 03, 2015 at 10:12 GMT


@thany It's not at all simple to revert to an older CEF -- which by the way, would bring back a whole bunch of other bugs that other Brackets users might care about. So please help us nag the CEF team to get it fixed, or submit a patch over there :-) That's the best route to resolving #10214. (Note: the issue described here has never worked, so I assume you're referring to #10214 instead).

core-ai-bot commented 3 years ago

Comment by thany Tuesday Mar 03, 2015 at 11:00 GMT


Another workaround you could add (or could have added) is a fixed scrolling distance for each tick of the scrollwheel. Just 3 lines, or 5 lines, or 100px, or whatever. Then don't respect the setting in the control panel. At least don't make it scroll half a screen for one tick.

I'm sure there are loads of libs in loads of languages, that provide something suitable.

Either way, I don't think it's fair to release a new version and not have fixed such an obvious regression bug.

core-ai-bot commented 3 years ago

Comment by avim Saturday Mar 14, 2015 at 23:37 GMT


I've that problem too and I will not update the version of brackets until this issue is fixed.

core-ai-bot commented 3 years ago

Comment by valnub Tuesday Mar 17, 2015 at 13:15 GMT


Same problem here. I wouldn't call this "low priority". It has a decent impact on the usability of Brackets. It's so annoying during coding that I am actually thinking about going back to Sublime :-(

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Mar 17, 2015 at 21:33 GMT


@avim@valnub You are both probably looking for #10214, not this bug.

core-ai-bot commented 3 years ago

Comment by thany Friday Oct 16, 2015 at 08:40 GMT


STILL not working in the latest update. Sorry guys, but this is getting embarassing.

core-ai-bot commented 3 years ago

Comment by 50l3r Thursday Mar 03, 2016 at 18:17 GMT


+1 I love Brackets but your scroll its very shitty :p

core-ai-bot commented 3 years ago

Comment by valnub Thursday Mar 03, 2016 at 18:51 GMT


I use Atom editor now. It's way superior compared to Brackets.

core-ai-bot commented 3 years ago

Comment by Lucas2929 Friday Apr 29, 2016 at 13:00 GMT


Try going to 'device drivers' click on 'mice and other pointing devices' when you click on that, it should drop down...In the drop down box,Find the driver that corresponds to the mouse your having issues with....RIght click on it----you'll get another drop down box...In that drop down, click on properties...When that screen opens-click on the 'driver' tab at the top....in the 'driver' tab click on 'roll back driver'......That's what made my mouse working correctly again when I was having the same issues....

core-ai-bot commented 3 years ago

Comment by thany Monday Jul 24, 2017 at 08:50 GMT


Progress update please?