search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Toggle Block Comment selection is inconsistent with multiple line selections #12618

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Saturday Apr 12, 2014 at 00:01 GMT Originally opened as https://github.com/adobe/brackets/issues/7495

  1. Open a JS file
  2. Create two cursors (using Cmd-click) on two lines that aren't adjacent
  3. Ctrl-L to select both lines
  4. Cmd-Alt-/ to block comment

Result: The first selection expands to include the end comment line, which it shouldn't. The second selection is correct.

core-ai-bot commented 3 years ago

Comment by njx Saturday Apr 12, 2014 at 00:02 GMT

This is probably a bug in how the comment logic was modified to handle multiple selections, not a bug in the comment logic itself. It reproduces both in master and in #7135.

/cc@TomMalbran - don't think you need to do anything about this but thought you might be interested.

core-ai-bot commented 3 years ago

Comment by pthiess Sunday Apr 13, 2014 at 21:01 GMT

@TomMalbran -- I took the liberty to assign this to you without knowing whether you're truly interested, please feel free to reassign to@njx anytime.

Thanks a ton!

core-ai-bot commented 3 years ago

Comment by TomMalbran Sunday Apr 13, 2014 at 21:14 GMT

@njx wrote the part that made it work with multiple cursors and I don't fully understand how it works. I would need to understand the code first. I guess it might be better if@njx fixed this.