search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Code cleanups for Find/Replace in Files #12711

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Tuesday Jun 17, 2014 at 01:11 GMT Originally opened as https://github.com/adobe/brackets/issues/8138

See #7705, #7809 and #8137.

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday Jun 17, 2014 at 23:30 GMT

Remove error-showing functionality from FindReplace.parseQuery()

That one could also be folded into any work we do to make the search APIs headless (I believe someone was working on a PR for that). There are a couple places, including parseQuery(), where we assume if a UI is present we should touch it -- and only operate truly headlessly if the search bar is currently closed. We'd probably need to fix all those cases before exposing a true headless API.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Jun 18, 2014 at 04:42 GMT

Clean up showError()/showNoResults() (combine them and/or make showNoResults() less confusing)

  • Small thread about code cleanup here: https://github.com/adobe/brackets/pull/7705#discussion_r13624830 -@TomMalbran suggested a UI cleanup: eliminate .no-results-message (the "No results" label that's prepended to the "in ..." scope label when Find/Replace in Files finds 0 hits -- and instead present the info in the same red dropdown that's used for other error cases (0 files to search / invalid regexp)
  • I noted we might want to wait in case changes in the Find result-count UI (which shares code with this) might affect what we'd do here. There's a near-future user story that changes it into an index indicator (updated during result navigation), and a PR proposal to make it an interactive element.
core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Jun 18, 2014 at 04:45 GMT

Move FindUtils.performReplacements() back into FindInFiles.doReplace()

Alternative suggestion: leave it in FindUtils and eliminate the wrapper FindInFiles.doReplace() -- just call it directly. If we moved performReplacements() into FindInFiles, it brings basically all of FindUtils with it... and it's sort of nice having that code separated out as it is currently.

core-ai-bot commented 3 years ago

Comment by njx Thursday Jun 19, 2014 at 16:17 GMT

@peterflynn Regarding making search headless, the existing PR from@zaggino is obsolete - for what he wants, using FindInFilesUI.searchAndShowResults() is probably good enough. But it would be nice to factor things out further.