search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Searching for invalid regular expression requires refresh to recover #12943

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by davemevans Thursday Nov 13, 2014 at 12:13 GMT Originally opened as https://github.com/adobe/brackets/issues/9921

When pressing enter to search, if an invalid regular expression has been entered, the cursor constantly spins, as do the brackets in the status bar. Only reloading the application recovers.

The application knows the search term is invalid (displays a pink banner) so should not allow it to be searched.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Nov 13, 2014 at 17:38 GMT

I can confirm. Looks like FindInFiles._doSearch() returns null, which causes FindInFilesUI.searchAndShowResults() to crash since it always expects to get a promise back. (Maybe it should just return a rejected promise?). I'm guessing this has been broken ever since 0.41.

Workaround - run Find in Files again, with a valid search query (despite the spinning cursor, you can still click and type to interact with the Brackets UI).