search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

Scroll to HTML/CSS element using live highlight when element is out of viewport #12947

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by voodoo6 Saturday Nov 15, 2014 at 11:17 GMT Originally opened as https://github.com/adobe/brackets/issues/9938

The live highlight feature is great.

However, if the element selected in brackets is out of view in the chrome viewport, chrome should scroll the window to show the elected element.

Thanks!

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Nov 17, 2014 at 21:58 GMT

Seems somewhat related to https://trello.com/c/vsSZQjj6/752-live-highlight-more-information.

I imagine we'd want the auto-scroll to be disable-able and/or on a slight delay, since it could be annoying to have the browser view jumping all over as you move your cursor through a CSS file. There's also the question of what to do when there are multiple highlights that don't all fit in view at once...

core-ai-bot commented 3 years ago

Comment by niutech Tuesday Aug 18, 2015 at 11:09 GMT

I support the idea of browser scrolling to the element selected in Brackets + Brackets scrolling to the element selected in browser. Will it be added to the backlog? I don't think it is related to #2232.

core-ai-bot commented 3 years ago

Comment by garretwilson Thursday Dec 10, 2015 at 15:37 GMT

Is there any progress on this?

core-ai-bot commented 3 years ago

Comment by siuangie91 Monday Sep 25, 2017 at 18:09 GMT

Is there a way to disable this actually? It's a great feature but for me the jumping around makes me very dizzy. (I wonder if anyone else is having this issue?)

core-ai-bot commented 3 years ago

Comment by swmitra Monday Sep 25, 2017 at 18:55 GMT

@siuangie91 If you are not using experimental live preview then you can set livedev.enableReverseInspect preference to false. This would disable the reverse inspect feature from the next live preview sessions. This preference is added from Brackets 1.11 released today.

core-ai-bot commented 3 years ago

Comment by siuangie91 Monday Sep 25, 2017 at 19:03 GMT

@swmitra Thanks for your response. I actually had livedev.enableReverseInspect preference set to false. I was referring to the "regular/forward" inspect; that is, when I click on an element in my HTML file, the browser window scrolls to that element if it's not within the current viewport. I wanted to disable this scrolling if possible. (I downgraded back to Brackets 1.8, where clicking on an element in my HTML file that's not within the browser viewport does not make it scroll to it.)

core-ai-bot commented 3 years ago

Comment by swmitra Monday Sep 25, 2017 at 19:13 GMT

@siuangie91 Thanks for clarifying 👍 As of today, Brackets doesn't have the required configuration to disable view port alignment in case of forward inspect. In fact that feature came into existence to resolve reported issues. Not sure if I am convinced of the use case you have explained. If I put my cursor on an element in HTML code, isn't it desirable to make sure that the element I am editing is actually what I intend to edit? And the only way to visually get the confirmation is to see that element in live preview page.

core-ai-bot commented 3 years ago

Comment by siuangie91 Monday Sep 25, 2017 at 19:25 GMT

Thanks@swmitra, I agree that the feature is helpful. It's just that sometimes I'm not clicking in Brackets to edit a specific element; rather, I'm clicking to return focus on Brackets app from say, Microsoft Word. When I do that, Brackets' live preview window scrolls to wherever I clicked on, even though I was only clicking on it to return focus on the Brackets editor.

It's the same as G3-Logic's reason on July 25th on #13307 but the other way around.

This frequent scrolling back and forth makes me super dizzy and I have to switch between apps a lot for my work.

Thanks for replying so fast!