Random visual glitches around the menu area v1.1 (Win 7)

core-ai-bot commented 3 years ago

Issue by wfdctrl Saturday Dec 20, 2014 at 21:50 GMT Originally opened as https://github.com/adobe/brackets/issues/10256

Since I upgraded to the new version(1.1), I have been noticing that the menu area is flashing at random times. I also get a similar glitch when I minimize the window.

core-ai-bot commented 3 years ago

Comment by redmunds Sunday Dec 21, 2014 at 00:02 GMT

@wfdctrl You'll need to provide more info. A screen shot and set of steps to reproduce each problem would be very helpful.

core-ai-bot commented 3 years ago

Comment by wfdctrl Sunday Dec 21, 2014 at 01:06 GMT

As I said the flashing seems to happen at random, so it is not directly triggered by any of my actions. It always happens when I am typing, so I never got a good look at it. It kind of looks like the glitch when you minimize the window. I'll try to take a video...

In the mean time I downgraded, because it was a bit distracting and I haven't had any problems since...

core-ai-bot commented 3 years ago

Comment by wfdctrl Sunday Dec 21, 2014 at 12:22 GMT

I reinstalled the new version and it doesn't recur when I pay attention to the upper corner of the screen. It could be possible that my peripheral vision is playing tricks on me.

On an unrelated note, the text started to turn green when I tried to reproduce the glitch. Should I open a new issue? screenshot 2014-12-21 02 28 37

core-ai-bot commented 3 years ago

Comment by redmunds Sunday Dec 21, 2014 at 16:23 GMT

@wfdctrl

the flashing seems to happen at random

Yes, everything seems random until you figure out what's happening :)

core-ai-bot commented 3 years ago

Comment by wfdctrl Sunday Dec 21, 2014 at 18:14 GMT

The glitch is also triggered when the window loses focus, however I can no longer reproduce it just by typing. I finally have the screen-cap:

line

core-ai-bot commented 3 years ago

Comment by nethip Wednesday Jan 21, 2015 at 11:22 GMT

@wfdctrl Do you have any programs installed on your system to customize windows themes? Possibly related https://github.com/adobe/brackets/issues/8890.

core-ai-bot commented 3 years ago

Comment by wfdctrl Wednesday Jan 21, 2015 at 20:34 GMT

No, I use the default theme, always have. Anyways my computer is a little sluggish today, therefore the window switching works slower than usual. Now I can see what’s actually going on. The default windows border and title bar peek through for a brief moment and the white lines I have been noticing are their edges. The flashing also happens when I press ctrl-s and that is how it was triggered while typing. :smile:

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 22, 2015 at 05:36 GMT

Btw, about "the text started to turn green": that's the normal, correct syntax highlighting. When you type a number in a JavaScript file, it will be color-coded green.

core-ai-bot commented 3 years ago

Comment by peterflynn Thursday Jan 22, 2015 at 05:37 GMT

Hmm, I can actually repro this today when switching windows too.

core-ai-bot commented 3 years ago

Comment by nethip Thursday Jan 22, 2015 at 08:30 GMT

@wfdctrl This can be reproe'd on Brackets 1.0 as well. It might not be that evident in 1.0, but you could still see the white line just in the project tree. This might have gotten worse in 1.1 as there is now a little more room between the menu bar and the editor. (see #10081).

core-ai-bot commented 3 years ago

Comment by wfdctrl Thursday Jan 22, 2015 at 10:53 GMT

@nethip yes, you’re probably right, when I first installed 1.1 version, there was constant flashing while I was typing (I compulsively press ctrl-s after every input). After I downgraded it was no longer triggered by saving, so it was as good as fixed for me. Then after I upgraded again I couldn't replicate that behavior, hence the confusion in my earlier comments...

@peterflynn about the green text: am not the sharpest tool in the shed at 3 in the morning :sweat_smile:

core-ai-bot commented 3 years ago

Comment by fxb Friday Feb 13, 2015 at 14:16 GMT

I think this could be caused by ScheduleMenuRedraw and MenuRedrawTimerHandler. Maybe try to not only call DrawMenuBar, but instead do whole DoPaintNonClientArea? Legacy windows code probably draws this white line, which needs to be drawn over again.

core-ai-bot commented 3 years ago

Comment by fxb Friday Feb 13, 2015 at 14:19 GMT

I also noticed this happening after a WM_NCACTIVATE / WM_ACTIVATE. Changing the following in cef_dark_aero_window.cpp seems to get rid of that, since the default WndProc doesn't get to draw weird stuff after our call to UpdateNonClientArea.

case WM_NCACTIVATE:
case WM_ACTIVATE:
    if (mReady) {
        UpdateNonClientArea();
    }
    break;

Changed to:

case WM_NCACTIVATE:
case WM_ACTIVATE:
    if (mReady) {
        UpdateNonClientArea();
    }
    return 0L;

core-ai-bot commented 3 years ago

Comment by nethip Thursday Mar 05, 2015 at 08:16 GMT

@fxb :clap: This indeed fixed this! Good job! Could you put up a PR for this.

core-ai-bot commented 3 years ago

Comment by frenic Monday Apr 27, 2015 at 11:39 GMT

Still having this issue in v1.3. Sometimes it looks randomly sticks like this until I move my cursor. In this case I expanded a directory. Would be nice close this with v1.4?

brackets snapshot

core-ai-bot commented 3 years ago

Comment by nethip Monday Apr 27, 2015 at 12:07 GMT

@faddee The PR https://github.com/adobe/brackets-shell/pull/507 is not yet merged with the master as we ran into couple of issues while unit testing.

core-ai-bot commented 3 years ago

Comment by frenic Monday Apr 27, 2015 at 12:19 GMT

@nethip Argh! Ok, thanks for the info and good work though! :-)

brackets-archive / bracketsIssues

Random visual glitches around the menu area v1.1 (Win 7) #13006